Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable READ_BLOCK_COMPACTION_MICROS to track stats #9722

Closed
wants to merge 4 commits into from
Closed

Enable READ_BLOCK_COMPACTION_MICROS to track stats #9722

wants to merge 4 commits into from

Conversation

Myasuka
Copy link
Contributor

@Myasuka Myasuka commented Mar 21, 2022

After commit d642c60, the stats READ_BLOCK_COMPACTION_MICROS cannot record any compaction read duration, and it always report zero.

This PR targets to distinguish READ_BLOCK_COMPACTION_MICROS with READ_BLOCK_GET_MICROS so that READ_BLOCK_COMPACTION_MICROS could record the correct stats.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jay-zhuang
jay-zhuang approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@jay-zhuang jay-zhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Myasuka would you please update HISTORY.md

@Myasuka Myasuka force-pushed the block-compaction-read branch from 0929e73 to 5565d8b Compare March 22, 2022 06:45
@facebook-github-bot
Copy link
Contributor

@Myasuka has updated the pull request. You must reimport the pull request before landing.

@Myasuka
Copy link
Contributor Author

Myasuka commented Mar 22, 2022

@jay-zhuang , thanks for your suggestion, already updated the HISTORY.md.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Myasuka has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@Myasuka has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Myasuka has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ajkr pushed a commit that referenced this pull request Mar 29, 2022
@Myasuka @ajkr
Enable READ_BLOCK_COMPACTION_MICROS to track stats (#9722)
92ea271 
Summary:
After commit [d642c60](d642c60), the stats `READ_BLOCK_COMPACTION_MICROS` cannot record any compaction read duration, and it always report zero.

This PR targets to distinguish `READ_BLOCK_COMPACTION_MICROS` with `READ_BLOCK_GET_MICROS` so that `READ_BLOCK_COMPACTION_MICROS` could record the correct stats.

Pull Request resolved: #9722

Reviewed By: ajkr

Differential Revision: D35021870

Pulled By: jay-zhuang

fbshipit-source-id: f1a804994265e51465de64c2a08f2e0eeb6fc5a3
ajkr pushed a commit that referenced this pull request Mar 29, 2022
@Myasuka @ajkr
Enable READ_BLOCK_COMPACTION_MICROS to track stats (#9722)
e7de808 
Summary:
After commit [d642c60](d642c60), the stats `READ_BLOCK_COMPACTION_MICROS` cannot record any compaction read duration, and it always report zero.

This PR targets to distinguish `READ_BLOCK_COMPACTION_MICROS` with `READ_BLOCK_GET_MICROS` so that `READ_BLOCK_COMPACTION_MICROS` could record the correct stats.

Pull Request resolved: #9722

Reviewed By: ajkr

Differential Revision: D35021870

Pulled By: jay-zhuang

fbshipit-source-id: f1a804994265e51465de64c2a08f2e0eeb6fc5a3
ajkr pushed a commit that referenced this pull request Apr 18, 2022
@Myasuka @ajkr
Enable READ_BLOCK_COMPACTION_MICROS to track stats (#9722)
6c86204 
Summary:
After commit [d642c60](d642c60), the stats `READ_BLOCK_COMPACTION_MICROS` cannot record any compaction read duration, and it always report zero.

This PR targets to distinguish `READ_BLOCK_COMPACTION_MICROS` with `READ_BLOCK_GET_MICROS` so that `READ_BLOCK_COMPACTION_MICROS` could record the correct stats.

Pull Request resolved: #9722

Reviewed By: ajkr

Differential Revision: D35021870

Pulled By: jay-zhuang

fbshipit-source-id: f1a804994265e51465de64c2a08f2e0eeb6fc5a3
@ti-chi-bot ti-chi-bot bot mentioned this pull request Dec 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay-zhuang jay-zhuang jay-zhuang approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Myasuka @facebook-github-bot @jay-zhuang