Code

Clean up VersionStorageInfo a bit#9494

Code

Closed

ltamasi wants to merge 17 commits intofacebook:mainfacebook/rocksdb:mainfrom ltamasi:vsi_cleanupltamasi/rocksdb:vsi_cleanupCopy head branch name to clipboard

+278-191

Commits

Commits on Feb 3, 2022

• Rename Version::PrepareApply to PrepareAppend

  ltamasi

  committed
  fc632ef

  Copy full SHA for fc632ef

• Update comment

  ltamasi

  committed
  fb809f8

  Copy full SHA for fb809f8

• Add some more details to comment

  ltamasi

  committed
  a76f4c5

  Copy full SHA for a76f4c5

• Move the ComputeCompensatedSizes call to PrepareAppend, only call UpdateAccumulatedStats if update_stats flag is set

  ltamasi

  committed
  a57429d

  Copy full SHA for a57429d

• Introduce a helper VersionStorageInfo::PrepareAppend

  ltamasi

  committed
  ecd0eb2

  Copy full SHA for ecd0eb2

• Use VersionStorageInfo::PrepareAppend in tests

  ltamasi

  committed
  68bdc3e

  Copy full SHA for 68bdc3e

• Fix up VersionStorageInfoTest.MaxBytesForLevelStatic

  ltamasi

  committed
  237ec0b

  Copy full SHA for 237ec0b

• Split VersionStorageInfoTest.MaxBytesForLevelDynamic into multiple test cases

  ltamasi

  committed
  79155ae

  Copy full SHA for 79155ae

• Call UpdateVersionStorageInfo in version_set_test

  ltamasi

  committed
  c4a888d

  Copy full SHA for c4a888d

• No need to explicitly set compensated_file_size in test

  ltamasi

  committed
  5caa26a

  Copy full SHA for 5caa26a

• Update version_builder_test

  ltamasi

  committed
  a4e655b

  Copy full SHA for a4e655b

• Remove unused method from test

  ltamasi

  committed
  bf03f43

  Copy full SHA for bf03f43

• OK to set compensated file size

  ltamasi

  committed
  8d08d5e

  Copy full SHA for 8d08d5e

• Make the helpers used by PrepareAppend private

  ltamasi

  committed
  da415cc

  Copy full SHA for da415cc

• Fix up some comments

  ltamasi

  committed
  449b897

  Copy full SHA for 449b897

• Rename VersionStorageInfo::PrepareAppend to PrepareForVersionAppend

  ltamasi

  committed
  8300251

  Copy full SHA for 8300251

Commits on Feb 4, 2022

• Small cleanup

  ltamasi

  committed
  dd527e3

  Copy full SHA for dd527e3