Update IOTrace operations in stackable_db.h #7514
Conversation
There was a problem hiding this comment.
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Update IOTrace operations in stackabledb.h and also trace few other IO operations. Test Plan: make check -j64 Reviewers: Subscribers: Tasks: Tags:
akankshamahajan15
force-pushed
the
io_tracing
branch
from
3a1ba59 to
6ab6c9d
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
These changes follow the style of the existing code. I created #7504 to document some of the issues with that style.
LGTM, with the aforementioned caveat.
|
@akankshamahajan15 merged this pull request in 7b65666. |
I added tests in io_tracer_test to cover testing of writing records in IOTracer and io_tracer_parser_test to cover writing the records through calling DB::StartIOTracer and then DB::EndIOTracer and parsing those records. |
Summary: Update IOTrace operations in stackabledb.h and also trace few other IO operations. Pull Request resolved: facebook#7514 Test Plan: make check -j64 Reviewed By: anand1976 Differential Revision: D24151202 Pulled By: akankshamahajan15 fbshipit-source-id: 112cd3d2041f8c6398b7b0ba1a783b8c93224d4a
Summary: Update IOTrace operations in stackabledb.h and also trace few other IO operations. Pull Request resolved: facebook/rocksdb#7514 Test Plan: make check -j64 Reviewed By: anand1976 Differential Revision: D24151202 Pulled By: akankshamahajan15 fbshipit-source-id: 112cd3d2041f8c6398b7b0ba1a783b8c93224d4a Signed-off-by: Changlong Chen <[email protected]>
Summary: Update IOTrace operations in stackabledb.h and also trace few other IO operations. Pull Request resolved: facebook/rocksdb#7514 Test Plan: make check -j64 Reviewed By: anand1976 Differential Revision: D24151202 Pulled By: akankshamahajan15 fbshipit-source-id: 112cd3d2041f8c6398b7b0ba1a783b8c93224d4a Signed-off-by: Changlong Chen <[email protected]>
Summary: Update IOTrace operations in stackabledb.h and also trace few
other IO operations.
Test Plan: make check -j64
Reviewers:
Subscribers:
Tasks:
Tags: