Log GetCurrentTime failures during Flush and Compaction #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing some tech debt from TTL-based FIFO compaction: T19827304 (internal). |
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
yiwu-arbug
reviewed
Dec 6, 2017
db/compaction_job.cc
Outdated
| auto status = db_options_.env->GetCurrentTime(&_current_time); | ||
| // Safe to proceed even if GetCurrentTime fails. So, log and proceed. | ||
| if (!status.ok()) { | ||
| ROCKS_LOG_DEBUG(db_options_.info_log, |
There was a problem hiding this comment.
worth to be on warning level?
There was a problem hiding this comment.
mention in the log the time is for getting creation_time in compactions?
There was a problem hiding this comment.
all good points. Updated the patch with these suggestions.
yiwu-arbug
reviewed
Dec 6, 2017
| db_options_.env->GetCurrentTime(&_current_time); // ignore error | ||
| auto status = db_options_.env->GetCurrentTime(&_current_time); | ||
| // Safe to proceed even if GetCurrentTime fails. So, log and proceed. | ||
| if (!status.ok()) { |
yiwu-arbug
approved these changes
Dec 6, 2017
|
@sagar0 has updated the pull request. View: changes, changes since last import |
|
thanks! |
There was a problem hiding this comment.
@sagar0 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetCurrentTime()is used to populatecreation_timetable property during flushes and compactions. It is safe to ignoreGetCurrentTime()failures here but they should be logged.(Note that
creation_timeproperty was introduced as part of TTL-based FIFO compaction in #2480.)Tes Plan:
make check