Fix caching of compaction picker's next index #2624
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of caching
file_size
index made no sense. It only remembered the original span of locked files starting from beginning offile_size
. We should remember the index after all compactions that have been considered but rejected. This will reduce the work we do while holding the db mutex.Test Plan: unit test (before this change,
vstorage_->NextCompactionIndex(1 /* level */)
would always return one)