-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update java/rocksjni.pom #2610
Update java/rocksjni.pom #2610
Conversation
java/rocksjni.pom
Outdated
@@ -19,6 +19,11 @@ | |||
<url>http://www.apache.org/licenses/LICENSE-2.0.html</url> | |||
<distribution>repo</distribution> | |||
</license> | |||
<license> | |||
<name>GNU General Public License, version 2</name> | |||
<url>http://opensource.org/licenses/gpl-2.0</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if the URL should actually link to https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html , or some link directly from gnu.org ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one we are using is https://www.gnu.org/licenses/gpl-2.0.txt
Maybe I should put that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, google search shows those links from gnu.org to be more authentic and lot more used. So, either one of those should be good.
@siying updated the pull request - view changes |
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@siying looks good to me. |
Summary: Closes #2610 Differential Revision: D5445705 Pulled By: siying fbshipit-source-id: d5f97ffdf5bc18b853c3a106755aca96a650e428
Summary: Closes #2610 Differential Revision: D5445705 Pulled By: siying fbshipit-source-id: d5f97ffdf5bc18b853c3a106755aca96a650e428
No description provided.