Fix edge case issue around unsubscribing live queries #4868
+268
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,7 +67,7 @@ hook useLazyLoadQueryNode<TQuery: OperationType>({ | |||
| fetchObservable, | |||
| fetchPolicy, | |||
| renderPolicy, | |||
| {start: startFetch, complete: completeFetch, error: completeFetch}, | |||
| undefined, | |||
There was a problem hiding this comment.
Could you help me understand why these are safe to remove?
There was a problem hiding this comment.
This was for calling .unsubscribe() when the component unmounts. However since the unsubscribe is now a no-op there's no point for keeping this anymore
| }, | ||
| }; | ||
| observerStart(subscriptionWithConditionalCancelation); | ||
| unsubscribe: () => {}, |
There was a problem hiding this comment.
Do live queries still get unsubscribed through some other means?
There was a problem hiding this comment.
Yeah it's managed by the .retain() stuff and is also ensured with the test added (the .toThrow() part)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only happens when...
useLazyLoadQueryNode()The fix is pretty simple though 😋