Add plural fragment support to observeFragment()
#4862
Conversation
|
Hi @XiNiHa! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
| }, | ||
| { | ||
| state: 'ok', | ||
| // $FlowFixMe[incompatible-cast]: TData is enforced to be an array |
There was a problem hiding this comment.
Not sure why this should be marked as $FlowFixMe when TData has : Array<mixed> enforcement
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Exciting! I'll take a look tomorrow. |
XiNiHa
force-pushed
the
observefragment-plural
branch
2 times, most recently
from
9e66202 to
9300e5a
Compare
XiNiHa
force-pushed
the
observefragment-plural
branch
from
e596faa to
75e4c26
Compare
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This PR adds plural fragment support to
observeFragment()(andwaitForFragmentData()which usesobserveFragment()under the hood)It should be noted that the Relay environment currently doesn't support subscribing to plural fragment updates, so the implementation is done by subscribing to each selector and merging the states. Since the current implementation doesn't do any batching of notifications that are made from each selector subscription, it can be somewhat inefficient if the consumer doesn't batch on their own.