Integrate missing required fields into errorResponseFields #4807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents the last major step in consolidating how field errors are modeled on Snapshot. Here we move missing required fields into the existing
errorResponseFields
(which should probably get renamed at some point) and are now directly stored in their event shape, rather than needing an intermediate shape.This comes with a few small changes:
@throwOnFieldError
on the fragment being read. This is important because we may inherit events from resolvers that we read.