Add new option to support compiling a single project #3868
Conversation
tbezman
force-pushed
the
single-project-compilation
branch
from
e4b86a9
to
d041784
Compare
| /// A list of projects to compile. | ||
| /// If excluded, all projects will be compiled | ||
| #[clap(long)] | ||
| projects: Vec<String>, |
There was a problem hiding this comment.
I would expect this to just be project and that you would specify it multiple times to specify multiple projects. Can you confirm what it actually looks like to pass multiple projects? I think it would be not great to have to pass multiple projects using one flag (how are you supposed to delineate them? commas? spaces?)
There was a problem hiding this comment.
yeah I think it doesn't do any space / command delimiting by default. I updated the language a bit to better explain.
There was a problem hiding this comment.
Cool. Can just make this --project?
| projects: Vec<String>, | |
| project: Vec<String>, |
There was a problem hiding this comment.
@captbaritone Incase it isn't clear from the code. I kept the rust name as projects since it truly is a list of projects to compile. The clap name is project since the user can pass projects like so --project projectA --project projectB
…w they can pass it multiple times
tbezman
force-pushed
the
single-project-compilation
branch
from
f55d061
to
11e05cf
Compare
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Add new option to support compiling a single project #3868
Usage
yarn relay-compiler -p projectA -p projectB