Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile with loose mode #265

Merged
merged 2 commits into from
Dec 8, 2016
Merged

compile with loose mode #265

merged 2 commits into from
Dec 8, 2016

Conversation

hzoo
Copy link
Contributor

@hzoo hzoo commented Dec 8, 2016

If we move the implementation maybe we want to be as close as possible to what it was before?

https://github.com/babel/babel/blob/26b4e0909ef8ec3a45b08f2a475124ed83defdac/package.json#L51-L66

{
"comments": false,
    "presets": [
      [
        "es2015",
        {
          "loose": true
        }
      ],
      "stage-0"
    ],
    "plugins": [
      "./scripts/add-module-exports",
      "transform-runtime",
      "transform-class-properties",
      "transform-flow-strip-types"
    ],
}

the other plugins/presets won't matter if the syntax isn't used so we can ignore that.

@benjamn benjamn merged commit acf11c4 into facebook:master Dec 8, 2016
@hzoo
Copy link
Contributor Author

hzoo commented Dec 8, 2016

thoughts on whether we also need to use add-module-exports or we do a require('x').default or we use imports syntax for babel/babel#4881 (comment)?

Or maybe it's just me, it seems to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants