Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn prettier runs a too long command for OS windows #9523

Closed
wants to merge 3 commits into from

Conversation

lamo2k123
Copy link
Contributor

fixed issue #9500

@gaearon
Copy link
Collaborator

gaearon commented Apr 25, 2017

Seems like CI integration failed, can you take a look at what happened?

@lamo2k123
Copy link
Contributor Author

@gaearon everything is fine, I forgot to launch yarn prettier :)

@gaearon
Copy link
Collaborator

gaearon commented Apr 26, 2017

I wonder if there's any speed difference here. What does Prettier recommend?
cc @vjeux

@vjeux
Copy link
Contributor

vjeux commented Apr 26, 2017

Instead of expanding the glob pattern in the call site, you can pass the glob pattern to prettier for it to expand it. This way you don't pass huge numbers of file paths through different programs.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the change suggested above please?

@gaearon
Copy link
Collaborator

gaearon commented Oct 31, 2017

Closing per lack of response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants