Remove IE8-specific ChangeEventPlugin logic #9281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix with prettier
aweary
force-pushed
the
remove-ie8-change-hack
branch
from
7e6a18b to
f005aba
Compare
|
👍. I'm working on a fix for scrolling issues (#1254 (comment)). What do you think about removing some of the IE8 specific checks while I'm at it? |
|
@nhunzaker sounds good to me, there's no reason to keep checks for an unsupported browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since React doesn't support IE8 anymore this logic can be removed, saving those precious bytes