Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more SSR unit tests for elements and children. #9221

Merged
merged 4 commits into from
Mar 24, 2017
Merged

Add more SSR unit tests for elements and children. #9221

merged 4 commits into from
Mar 24, 2017

Commits on Mar 20, 2017

  1. Adding more SSR unit tests for elements and children.

    @aickin
    aickin committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    828cae1 View commit details
    Browse the repository at this point in the history

  2. Some of my SSR tests were testing for react-text and react-empty elem… 

    …ents that no longer exist in Fiber. Fixed the tests so that they expect correct markup in Fiber.
    @aickin
    aickin committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    2781c49 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2017

  1. Tweaked some test names after @gaearon review comment facebook#9221 (… 

    …comment) . Also realized that one of the tests was essentially a direct copy of another, so deleted it.
    @aickin
    aickin committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    091d7fd View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2017

  1. Responding to code review facebook#9221 (review) . Thanks @spicyj!

    @aickin
    aickin committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    0d389f8 View commit details
    Browse the repository at this point in the history