Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rollup build #9147

Closed
wants to merge 175 commits into from
Closed
Show file tree
Hide file tree
Changes from 117 commits
Commits
Show all changes
175 commits
Select commit Hold shift + click to select a range
30c8371
WIP
trueadm Mar 7, 2017
9d78fa8
fbjs support
trueadm Mar 7, 2017
3c24a4c
WIP
trueadm Mar 7, 2017
d00cf55
dev/prod mode WIP
trueadm Mar 7, 2017
238dcf7
More WIP
trueadm Mar 7, 2017
15b13cd
builds a cjs bundle
trueadm Mar 8, 2017
690a72b
adding forwarding modules
trueadm Mar 8, 2017
ff0c871
more progress on forwarding modules and FB config
trueadm Mar 9, 2017
47fa99e
improved how certain modules get inlined for fb and cjs
trueadm Mar 9, 2017
8ef3aa5
more forwarding modules
trueadm Mar 9, 2017
fdb6e23
added comments to the module aliasing code
trueadm Mar 9, 2017
6114597
made ReactPerf and ReactTestUtils bundle again
trueadm Mar 9, 2017
a09bed0
Use -core suffix for all bundles
gaearon Mar 9, 2017
723b402
Add a lazy shim for ReactPerf
gaearon Mar 10, 2017
955b7e7
Fix forwarding module for ReactCurrentOwner
gaearon Mar 10, 2017
c9499d1
Revert "Add a lazy shim for ReactPerf"
gaearon Mar 10, 2017
c20ceeb
Rename -core suffix to -fb for clarity
gaearon Mar 10, 2017
c4dfd17
Change forwarding modules to import from -fb
gaearon Mar 10, 2017
ccfefc8
should fix fb and cjs bundles for ReactCurrentOwner
trueadm Mar 10, 2017
165bc45
added provides module for ReactCurrentOwner
trueadm Mar 10, 2017
65f11ee
should improve console output
trueadm Mar 10, 2017
7f6ecb1
fixed typo with argument passing on functon call
trueadm Mar 10, 2017
b34e7cf
Revert "should improve console output"
gaearon Mar 10, 2017
0a50b6a
Work around internal FB transform require() issue
gaearon Mar 10, 2017
71d6c3b
moved ReactInstanceMap out of React and into ReactDOM and ReactDOMFiber
trueadm Mar 10, 2017
063067d
Expose more internal modules to www
gaearon Mar 10, 2017
f6e5d72
Add missing modules to Stack ReactDOM to fix UFI
gaearon Mar 10, 2017
1f66be3
Fix onlyChild module
gaearon Mar 10, 2017
bd4d7ec
improved the build tool
trueadm Mar 10, 2017
ef50945
Add a rollup npm script
gaearon Mar 10, 2017
b82ba71
Rename ReactDOM-fb to ReactDOMStack-fb
gaearon Mar 10, 2017
95a4fbb
Fix circular dependencies now that ReactDOM-fb is a GK switch
gaearon Mar 10, 2017
3f89a77
Merge branch 'master' into rollup
gaearon Mar 10, 2017
4580b6b
Revert "Work around internal FB transform require() issue"
gaearon Mar 10, 2017
9ba6635
Bump rollup-plugin-commonjs to include a fix for rollup/rollup-plugin…
gaearon Mar 10, 2017
c2ffdcb
Add more forwarding modules that are used on www
gaearon Mar 10, 2017
1cc4278
Add even more forwarding modules that are used on www
gaearon Mar 11, 2017
f102045
Add DOMProperty to hidden exports
gaearon Mar 11, 2017
76ee978
Externalize feature flags
gaearon Mar 11, 2017
8a92f33
Remove forwarding modules with implementations
gaearon Mar 11, 2017
ae1f762
Add all injection necessary for error logging
gaearon Mar 11, 2017
3d27a04
Add missing forwarding module (oops)
gaearon Mar 11, 2017
d93b8e3
Add ReactART builds
gaearon Mar 11, 2017
32eccd5
Add ReactDOMServer bundle
gaearon Mar 11, 2017
31a9719
Fix UMD build of ReactDOMFiber
gaearon Mar 11, 2017
1eed4e1
Merge branch 'master' into rollup
gaearon Mar 11, 2017
2c9ea97
Merge branch 'master' into rollup
gaearon Mar 15, 2017
7a28190
Work in progress: start adding ReactNative bundle
gaearon Mar 15, 2017
04972cd
tidied up the options for bundles, so they can define what types they…
trueadm Mar 15, 2017
e4fcbec
Add a working RN build
gaearon Mar 16, 2017
8fa5d94
Merge branch 'master' into rollup
gaearon Mar 16, 2017
d5b91d3
further improved and tidied up build process
trueadm Mar 18, 2017
6aa9936
improved how bundles are built by exposing externals and making the p…
trueadm Mar 20, 2017
9255c64
better handling of bundling ReactCurrentOwner and accessing it from r…
trueadm Mar 20, 2017
14324bc
added NODE_DEV and NODE_PROD
trueadm Mar 21, 2017
4a578db
Fixed merge conflicts in ReactNative.js and ReactMethodsMixin.js
trueadm Mar 21, 2017
0e2f671
added NPM package creation and copying into build chain
trueadm Mar 21, 2017
e8f49c4
Improved UMD bundles, added better fixture testing and doc plus prod …
trueadm Mar 22, 2017
39a8b69
updated internal modules (WIP)
trueadm Mar 22, 2017
373e15b
fixed merge conflict
trueadm Mar 22, 2017
feda028
removed all react/lib/* dependencies from appearing in bundles create…
trueadm Mar 22, 2017
e8a2318
added react-test-renderer bundles
trueadm Mar 23, 2017
02b70bc
renamed bundles and paths
trueadm Mar 23, 2017
b4100ed
fixed fixture path changes
trueadm Mar 23, 2017
c81f2fb
added extract-errors support
trueadm Mar 23, 2017
37d334b
added extractErrors warning
trueadm Mar 23, 2017
dd0ae1a
moved shims to shims directory in rollup scripts
trueadm Mar 23, 2017
47e8057
changed pathing to use build rather than build/rollup
trueadm Mar 23, 2017
700894a
updated release doc to reflect some rollup changes
trueadm Mar 23, 2017
07a963a
Updated ReactNative findNodeHandle() to handle number case (#9238)
bvaughn Mar 23, 2017
26fa2cd
Add dynamic injection to ReactErrorUtils (#9246)
gaearon Mar 23, 2017
4d1584b
Fix ReactErrorUtils injection (#9247)
gaearon Mar 23, 2017
779d5bd
Fix merge conflict
gaearon Mar 23, 2017
d09410b
Fix Haste name
gaearon Mar 23, 2017
4458f15
Move files around
gaearon Mar 23, 2017
05bd00a
More descriptive filenames
gaearon Mar 23, 2017
c84f4e0
Add missing ReactErrorUtils shim
gaearon Mar 23, 2017
a57e140
Tweak reactComponentExpect to make it standalone-ish in www
gaearon Mar 23, 2017
bd4ff9d
Unflowify shims
gaearon Mar 24, 2017
8af3ca2
facebook-www shims now get copied over correctly to build
trueadm Mar 24, 2017
beaf32c
removed unnecessary resolve
trueadm Mar 24, 2017
b4f9895
building facebook-www/build is now all sync to prevent IO issues plus…
trueadm Mar 24, 2017
b5bdf70
Merge branch 'rollup' of github.com:trueadm/react into rollup
trueadm Mar 24, 2017
0fd8aa6
removed react-native-renderer package and made build make a react-nat…
trueadm Mar 24, 2017
4691521
Merge branch 'master' into rollup
gaearon Mar 24, 2017
7dba33b
😭😭😭
gaearon Mar 24, 2017
60e78e3
Add more SSR unit tests for elements and children. (#9221)
aickin Mar 24, 2017
c5156eb
ReactElementValidator uses temporary ReactNative View propTypes gette…
bvaughn Mar 24, 2017
71a87bc
Updating packages for 16.0.0-alpha.6 release
Mar 24, 2017
56c42b5
Revert "😭😭😭"
gaearon Mar 25, 2017
9347ca0
Work around Jest issue with CurrentOwner shared state in www
gaearon Mar 25, 2017
7afb09e
updated error codes
trueadm Mar 27, 2017
d526452
fixed merge conflicts with upstream master
trueadm Mar 27, 2017
9e5271a
splits FB into FB_DEV and FB_PROD
trueadm Mar 27, 2017
5f994ee
Remove deps on specific builds from shims
gaearon Mar 27, 2017
c95ee10
should no longer mangle FB_PROD output
trueadm Mar 27, 2017
4e81eac
Merge branch 'rollup' of github.com:trueadm/react into rollup
trueadm Mar 27, 2017
b025c43
Added init() dev block to ReactTestUtils
trueadm Mar 27, 2017
88293c7
added shims for DEV only code so it does not get included in prod bun…
trueadm Mar 27, 2017
65aae08
added a __DEV__ wrapping code to FB_DEV
trueadm Mar 27, 2017
ceeebd8
added __DEV__ flag behind a footer/header
trueadm Mar 27, 2017
02a0b8c
Use right haste names
gaearon Mar 27, 2017
f79b32a
keeps comments in prod
trueadm Mar 27, 2017
607b021
added external babel helpers plugin
trueadm Mar 29, 2017
28e9cb2
fixed fixtures and updated cjs/umd paths
trueadm Mar 29, 2017
77add81
Merge branch 'master' into rollup
gaearon Mar 29, 2017
1ed2b03
Fixes Jest so it run tests correctly
trueadm Mar 29, 2017
99df11d
Merge branch 'rollup' of github.com:trueadm/react into rollup
trueadm Mar 29, 2017
0248811
fixed an issue with stubbed modules not properly being replaced due t…
trueadm Mar 29, 2017
0e0bb5a
added a WIP solution for ReactCurrentOwner on FB DEV
trueadm Mar 29, 2017
33fa7c3
adds a FB_TEST bundle
trueadm Mar 29, 2017
ee37df1
allows both ReactCurrentOwner and react/lib/ReactCurrentOwner
trueadm Mar 29, 2017
272a6d4
adds -test to provides module name
trueadm Mar 29, 2017
7e7ca63
Remove TEST env
gaearon Mar 29, 2017
d86e827
Ensure requires stay at the top
gaearon Mar 29, 2017
221b611
added basic mangle support (disbaled by default)
trueadm Mar 30, 2017
e1fbc7a
Merge branch 'rollup' of github.com:trueadm/react into rollup
trueadm Mar 30, 2017
5893056
per bundle property mangling added
trueadm Mar 30, 2017
794e0b9
moved around plugin order to try and fix deadcode requires as per htt…
trueadm Mar 30, 2017
0017318
Merge branch 'master' into rollup
gaearon Mar 31, 2017
89199ac
Fix flow issues
gaearon Mar 31, 2017
16fc8d2
removed gulp and grunt and moved tasks to standalone node script
trueadm Mar 31, 2017
373f812
Merge branch 'rollup' of github.com:trueadm/react into rollup
trueadm Mar 31, 2017
c13c82e
configured circleci to use new paths
trueadm Mar 31, 2017
eb265f3
Fix lint
gaearon Mar 31, 2017
4da9ea5
removed gulp-extract-errors
trueadm Mar 31, 2017
a449c15
added test_build.sh back in
trueadm Mar 31, 2017
dad841e
Merge branch 'rollup' of github.com:trueadm/react into rollup
trueadm Mar 31, 2017
082b784
added missing newline to flow.js
trueadm Mar 31, 2017
3a671b2
fixed test coverage command
trueadm Mar 31, 2017
0f93e6a
changed permissions on test_build.sh
trueadm Mar 31, 2017
9ac0159
fixed test_html_generations.sh
trueadm Mar 31, 2017
70cc5f9
temp removed html render test
trueadm Mar 31, 2017
4dc1c51
removed the warning output from test_build, the build should do this …
trueadm Mar 31, 2017
63aeb43
fixed test_build
trueadm Mar 31, 2017
11f02c5
fixed broken npm script
trueadm Mar 31, 2017
796e89d
Merge branch 'master' into rollup
gaearon Mar 31, 2017
0820c0e
Remove unused ViewportMetrics shim
gaearon Mar 31, 2017
8e97503
Merge branch 'master' into rollup
gaearon Mar 31, 2017
ff86c3a
better error output
trueadm Mar 31, 2017
ae0cdc8
Merge branch 'rollup' of github.com:trueadm/react into rollup
trueadm Mar 31, 2017
e18e75c
updated circleci to node 7 for async/await
trueadm Mar 31, 2017
e628f40
Fixes
gaearon Mar 31, 2017
e7a6153
removed coverage test from circleci run
trueadm Mar 31, 2017
815f208
circleci run tets
trueadm Mar 31, 2017
fbeea6d
removed build from circlci
trueadm Apr 3, 2017
5108963
made a dedicated jest script in a new process
trueadm Apr 3, 2017
0c4f01b
moved order around of circlci tasks
trueadm Apr 3, 2017
64559f8
changing path to jest in more circleci tests
trueadm Apr 3, 2017
0364501
re-enabled code coverage
trueadm Apr 3, 2017
40cfc0c
Add file header to prod bundles
gaearon Apr 3, 2017
3bcde75
Remove react-dom/server.js (WIP: decide on the plan)
gaearon Apr 3, 2017
b00cdb8
Only UMD bundles need version header
gaearon Apr 3, 2017
69714d2
Merge with master
gaearon Apr 3, 2017
b62f7b1
Merge branch 'master' into rollup
gaearon Apr 3, 2017
2708cec
disabled const evaluation by uglify for <script></script> string literal
trueadm Apr 4, 2017
4fa30df
deal with ART modules for UMD bundles
trueadm Apr 4, 2017
c102dfe
improved how bundle output gets printed
trueadm Apr 4, 2017
cc6dba5
fixed filesize difference reporting
trueadm Apr 4, 2017
625419c
added filesize dep
trueadm Apr 4, 2017
cf10b81
Update yarn lockfile for some reason
gaearon Apr 4, 2017
3ef295c
now compares against the last run branch built on
trueadm Apr 4, 2017
5a4f84b
Merge branch 'rollup' of github.com:trueadm/react into rollup
trueadm Apr 4, 2017
202fd54
added react-dom-server
trueadm Apr 4, 2017
5e95acf
removed un-needed comment
trueadm Apr 4, 2017
40d9b38
results only get saved on full builds
trueadm Apr 4, 2017
c319500
moved the rollup sized plugin into a plugins directory
trueadm Apr 4, 2017
8450522
added a missing commonjs()
trueadm Apr 4, 2017
245c082
fixed missing ignore
trueadm Apr 4, 2017
59445a6
Hack around to fix RN bundle
gaearon Apr 4, 2017
23d46a8
Merge remote-tracking branch 'upstream/master' into rollup
trueadm Apr 4, 2017
4f0d34a
Partially fix RN bundles
gaearon Apr 4, 2017
3393a7f
added react-art bundle and a fixture for it
trueadm Apr 4, 2017
ef3e751
Merge branch 'rollup' of github.com:trueadm/react into rollup
trueadm Apr 4, 2017
b564dd0
Point UMD bundle to Fiber and add EventPluginHub to exported internals
gaearon Apr 4, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@
"transform-es2015-parameters",
["transform-es2015-destructuring", { "loose": true }],
["transform-es2015-block-scoping", { "throwIfClosureRequired": true }],
"transform-es2015-modules-commonjs",
"transform-es3-member-expression-literals",
"transform-es3-property-literals",
"./scripts/babel/transform-object-assign-require",
"transform-react-jsx-source"
"transform-es3-property-literals"
]
}
6 changes: 3 additions & 3 deletions examples/basic/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ <h4>Example Details</h4>
Learn more about React at
<a href="https://facebook.github.io/react" target="_blank">facebook.github.io/react</a>.
</p>
<script src="../../build/react.js"></script>
<script src="../../build/react-dom.js"></script>
<script src="../../build/react.min.js"></script>
<script src="../../build/react-dom-fiber.min.js"></script>
<script>
var ExampleApplication = React.createClass({
render: function() {
Expand All @@ -42,7 +42,7 @@ <h4>Example Details</h4>

var start = new Date().getTime();
setInterval(function() {
ReactDOM.render(
ReactDOMFiber.render(
ExampleApplicationFactory({elapsed: new Date().getTime() - start}),
document.getElementById('container')
);
Expand Down
14 changes: 3 additions & 11 deletions fixtures/packaging/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,13 @@ pushstate-server .

(Too complicated? Send a PR to simplify this :-).

Then open the corresponding URLs, for example:
Then open the following URL in your browser:

```
open http://localhost:9000/fixtures/globals.html
open http://localhost:9000/fixtures/requirejs.html
open http://localhost:9000/fixtures/systemjs.html
open http://localhost:9000/fixtures/browserify/index.html
open http://localhost:9000/fixtures/brunch/index.html
open http://localhost:9000/fixtures/rjs/index.html
open http://localhost:9000/fixtures/systemjs-builder/index.html
open http://localhost:9000/fixtures/webpack/index.html
open http://localhost:9000/fixtures/webpack-alias/index.html
open http://localhost:9000/fixtures/packaging/index.html
```

You should see two things:

* "Hello World" is rendered.
* "Hello World" is rendered in each iframe.
* No errors in the console.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"browserify": "^13.3.0"
},
"scripts": {
"build": "rm -f output.js && NODE_PATH=../../../build/packages browserify ./input.js -o output.js"
"build": "rm -f output.js && NODE_PATH=../../../../build/packages browserify ./input.js -o output.js"
}
}
Loading