Add a section about es6 object shorthand #9115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Maybe we should link to an external resource, too? |
gaearon
reviewed
Mar 12, 2017
docs/docs/jsx-in-depth.md
Outdated
| myPropsOne: this.props.myPropsOne, | ||
| myPropsTow: this.props.myPropsTwo | ||
| }; | ||
| return ( |
There was a problem hiding this comment.
I would just type props manually in the second example.
<MyComponent
myPropsOne={this.myPropsOne}
myPropsTwo={this.myPropsTwo} />
gaearon
reviewed
Mar 12, 2017
docs/docs/jsx-in-depth.md
Outdated
| @@ -245,6 +245,32 @@ function App2() { | |||
|
|
|||
| Spread attributes can be useful when you are building generic containers. However, they can also make your code messy by making it easy to pass a lot of irrelevant props to components that don't care about them. We recommend that you use this syntax sparingly. | |||
|
|
|||
| ### ES6 Object Shorthand | |||
|
|
|||
| If you want to filter the props that you want to pass, you can do it by using ES6 Object Shorthand in combination with object spread operator and object destructuring assignment: | |||
gaearon
requested changes
Mar 12, 2017
docs/docs/jsx-in-depth.md
Outdated
| If you want to filter the props that you want to pass, you can do it by using ES6 Object Shorthand in combination with object spread operator and object destructuring assignment: | ||
|
|
||
| ```js{4} | ||
| render(){ |
docs/docs/jsx-in-depth.md
Outdated
| ``` | ||
| This is roughly equivalent to a code that looks like this: | ||
| ```js{4} | ||
| render(){ |
docs/docs/jsx-in-depth.md
Outdated
| render(){ | ||
| const {myPropsOne, myPropsTwo} = this.props; | ||
| return ( | ||
| <MyComponent {...{myPropsOne, myPropsTwo}} /> |
There was a problem hiding this comment.
Please use more realistic prop names than myPropsOne, myPropsTwo. Maybe onClick and value.
|
Thank you for filing this PR! I'm sorry to be the bearer of bad news, but the documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.) Would you be willing to re-open this PR on the new repo? I promise we'll review it quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite sure if the heading should be ES6 Object Shorthand or Filtering Props. Thoughts?