[Fiber] Component lifecycle tests #8949

acdlite · 2017-02-07T21:41:27Z

Fixes tests in ReactComponentLifeCycle-test.js

Biggest change is to set current owner to null at beginning of commit phase.

acdlite · 2017-02-07T22:50:57Z

scripts/fiber/tests-failing.txt

-src/renderers/shared/shared/__tests__/ReactComponentLifeCycle-test.js
-* should carry through each of the phases of setup
+src/renderers/shared/shared/__tests__/ReactCompositeComponentState-test.js
+* should batch unmounts


Oops just noticed this

Guh. Sorry for missing it.

sebmarkbage · 2017-02-07T22:59:59Z

src/renderers/shared/fiber/ReactFiberCommitWork.js

@@ -343,6 +344,7 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
        if (typeof instance.componentWillUnmount === 'function') {
          safelyCallComponentWillUnmount(current, instance);
        }
+        ReactInstanceMap.remove(instance);


Never safe to rely on unmount.

gaearon · 2017-02-07T23:03:30Z

src/renderers/shared/shared/__tests__/ReactCompositeComponentState-test.js

@@ -345,6 +349,15 @@ describe('ReactCompositeComponent-state', () => {
    expect(() => {
      ReactDOM.unmountComponentAtNode(container);
    }).not.toThrow();
+
+    // Stack doesn't warn
+    if (ReactDOMFeatureFlags.useFiber) {


Why?

Also, if it doesn't warn, do you think this could create warning noise in codebases that already rely on this pattern? It would be nice to check Power Editor and other React-heavy projects for this.

My hunch is that setState on an unmounting parent in componentWillUnmount isn't that common but yeah I'll check

Code changed, moot now anyway

sebmarkbage

Life cycle test needs to be replaced by something like isMounted. The instance map is not safe.

acdlite · 2017-02-08T00:52:14Z

@sebmarkbage Updated

Need to reset current owner to null before committing

sebmarkbage · 2017-02-08T18:33:53Z

src/renderers/shared/fiber/ReactFiberClassComponent.js

@@ -41,7 +41,7 @@ var invariant = require('invariant');
 const isArray = Array.isArray;

 module.exports = function(
-  scheduleUpdate : (fiber : Fiber, priorityLevel : PriorityLevel) => void,
+  scheduleUpdate : (fiber : Fiber, priorityLevel : PriorityLevel, callerName : string | null) => void,


I'm not a fan of this pattern since they don't get stripped in prod. Can we reword it to be setState, replaceState or forceUpdate in the message instead of complicating the code?

I'm passing null in prod. But yeah, I like that better anyway.

Should do the same in ReactFiberUpdateQueue https://github.com/facebook/react/blob/master/src/renderers/shared/fiber/ReactFiberUpdateQueue.js#L217

acdlite · 2017-02-08T19:03:54Z

@sebmarkbage Updated again

acdlite · 2017-02-08T19:09:11Z

Forgot to update the Stack warnings

acdlite · 2017-02-08T19:24:18Z

Fixed

We want to avoid passing around caller names because stripping them out in production complicates the code for little benefit.

sebmarkbage

Don't forget to update the whitelists!

gaearon · 2017-02-23T13:58:57Z

src/renderers/dom/shared/findDOMNode.js

        '%s is accessing findDOMNode inside its render(). ' +
        'render() should be a pure function of props and state. It should ' +
        'never access something that requires stale data from the previous ' +
        'render, such as refs. Move this logic to componentDidMount and ' +
        'componentDidUpdate instead.',
        getComponentName(owner) || 'A component'
      );
-      (owner: any)._warnedAboutRefsInRender = true;


Oops. Should we preventExtensions on fibers? Like we do in Stack instantiate.

Yea. Let's add it in the constructor in DEV.

But expandos on the class isn't really better neither.

acdlite requested review from sophiebits, bvaughn and gaearon February 7, 2017 21:41

facebook-github-bot added CLA Signed GH Review: review-needed labels Feb 7, 2017

sebmarkbage mentioned this pull request Feb 7, 2017

[Fiber] Umbrella for remaining features / bugs #7925

Closed

acdlite mentioned this pull request Feb 7, 2017

[Fiber] ReactCompositeComponent-test.js #8950

Merged

bvaughn approved these changes Feb 7, 2017

View reviewed changes

acdlite commented Feb 7, 2017

View reviewed changes

acdlite force-pushed the fibercomponentlifecycletests branch 2 times, most recently from 7e26a90 to 38ecbc1 Compare February 7, 2017 22:57

sebmarkbage reviewed Feb 7, 2017

View reviewed changes

gaearon reviewed Feb 7, 2017

View reviewed changes

sebmarkbage requested changes Feb 7, 2017

View reviewed changes

acdlite force-pushed the fibercomponentlifecycletests branch from 38ecbc1 to 617e7d3 Compare February 8, 2017 00:51

acdlite added 3 commits February 8, 2017 10:31

Warn about isMounted inside render

4d52ebc

Warn if findDOMNode is used inside render

76a168f

Need to reset current owner to null before committing

Use isMounted instead of instance map to check if mounted

3955e22

sebmarkbage reviewed Feb 8, 2017

View reviewed changes

acdlite force-pushed the fibercomponentlifecycletests branch 2 times, most recently from 426acd9 to c725ed4 Compare February 8, 2017 19:03

Warn about calling setState on an unmounted component

e9aca8e

acdlite force-pushed the fibercomponentlifecycletests branch from c725ed4 to e9aca8e Compare February 8, 2017 19:24

Make Stack error message more generic, too

5b181a6

We want to avoid passing around caller names because stripping them out in production complicates the code for little benefit.

sebmarkbage approved these changes Feb 22, 2017

View reviewed changes

acdlite merged commit 2081a00 into facebook:master Feb 22, 2017

gaearon reviewed Feb 23, 2017

View reviewed changes

acdlite mentioned this pull request Feb 23, 2017

[Fiber] Prevent extensions to fiber in DEV #9054

Merged

snyk-bot mentioned this pull request Dec 2, 2022

[Snyk] Security upgrade vercel from 20.1.4 to 28.7.1 ryan-ally/react-1#170

Open

ryan-ally mentioned this pull request Jun 24, 2023

[Snyk] Fix for 1 vulnerabilities ryan-ally/react-1#233

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fiber] Component lifecycle tests #8949

[Fiber] Component lifecycle tests #8949

acdlite commented Feb 7, 2017 •

edited

Loading

acdlite Feb 7, 2017

bvaughn Feb 7, 2017

sebmarkbage Feb 7, 2017

gaearon Feb 7, 2017

acdlite Feb 7, 2017 •

edited

Loading

acdlite Feb 8, 2017

sebmarkbage left a comment •

edited

Loading

acdlite commented Feb 8, 2017

sebmarkbage Feb 8, 2017

acdlite Feb 8, 2017

acdlite Feb 8, 2017

sebmarkbage Feb 8, 2017

acdlite commented Feb 8, 2017

acdlite commented Feb 8, 2017 •

edited

Loading

acdlite commented Feb 8, 2017

sebmarkbage left a comment

gaearon Feb 23, 2017

sebmarkbage Feb 23, 2017

sebmarkbage Feb 23, 2017

[Fiber] Component lifecycle tests #8949

[Fiber] Component lifecycle tests #8949

Conversation

acdlite commented Feb 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acdlite Feb 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebmarkbage left a comment • edited Loading

Choose a reason for hiding this comment

acdlite commented Feb 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acdlite commented Feb 8, 2017

acdlite commented Feb 8, 2017 • edited Loading

acdlite commented Feb 8, 2017

sebmarkbage left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acdlite commented Feb 7, 2017 •

edited

Loading

acdlite Feb 7, 2017 •

edited

Loading

sebmarkbage left a comment •

edited

Loading

acdlite commented Feb 8, 2017 •

edited

Loading