Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Fix formatting of invalid element invariant #8908

Merged
merged 1 commit into from
Feb 1, 2017
Merged

[Fiber] Fix formatting of invalid element invariant #8908

merged 1 commit into from
Feb 1, 2017

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jan 31, 2017

Message is slightly different for functional and class components.

@acdlite
Fix formatting of invalid element invariant
2afcf6e 
Message is slightly different for functional and class components.
@sebmarkbage sebmarkbage mentioned this pull request Jan 31, 2017
Closed
gaearon
gaearon approved these changes Jan 31, 2017
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. We'll need to check if createWarning.js internally depends on this message and change it if it's there too.

@sophiebits
Copy link
Collaborator

sophiebits commented Jan 31, 2017 •
edited
Loading

This is an invariant, so it's okay.

@acdlite acdlite merged commit c158ff6 into facebook:master Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@sophiebits sophiebits sophiebits approved these changes

Assignees

@sophiebits sophiebits

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @sophiebits @gaearon @facebook-github-bot