-
Notifications
You must be signed in to change notification settings - Fork 48.3k
Fix Flow issue and revert to showing "Unknown" in warnings for anonymous components #8863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can't really understand why it fails |
The CI shows that a previously passing test now fails in Fiber mode: --- a/scripts/fiber/tests-passing-except-dev.txt
+++ b/scripts/fiber/tests-passing-except-dev.txt
@@ -116,3 +116,4 @@ src/renderers/shared/shared/__tests__/ReactMultiChild-test.js
src/renderers/shared/shared/__tests__/ReactStatelessComponent-test.js
* should warn for childContextTypes on a functional component
+* deduplicates ref warnings based on element or owner
diff --git a/scripts/fiber/tests-passing.txt b/scripts/fiber/tests-passing.txt
index 050dd41..189f341 100644
--- a/scripts/fiber/tests-passing.txt
+++ b/scripts/fiber/tests-passing.txt
@@ -1560,7 +1560,6 @@ src/renderers/shared/shared/__tests__/ReactStatelessComponent-test.js
* should throw on string refs in pure functions
* should warn when given a string ref
* should warn when given a function ref
-* deduplicates ref warnings based on element or owner
* should provide a null ref Read how to run tests in Fiber mode: #7925 (comment). |
It's likely failing because two different classes are |
Okay, so it turned out we have a bunch of call sites that explicitly check for So |
Yeah I noticed that as well. I will revert to null |
Sorry for the churn 😅 |
No worries :D |
I don't think this will pass Flow, would it? It’s effectively |
oops.. missed that one.. |
success 🎉 |
For future reference, this fixes mistakes made in #8857 and #8858.