-
Notifications
You must be signed in to change notification settings - Fork 47.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass event obj to the method #8668
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
Thanks for the PR @mitenka! I think the change is good (as it demonstrates the argument is passed on the the class method), but it feels weird not actually using it. Can you think of a way we can update the example so it actually uses the |
Let's not add "needs merge to stable" until we merge to master? Otherwise it's easy to accidentally get it merged before it's approved. |
My bad, I usually add labels after merge, guess it's a habit adding both at once |
@aweary, maybe it would be better to remove |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@aweary is there any more work to do on this, or is this just in need of review? |
Thank you for submitting this PR! 😄 Unfortunately the documentation and source code for reactjs.org has been moved to a different repository: https://github.com/reactjs/reactjs.org If you are willing, please open a new PR there. Sorry for the inconvenience! (For more backstory on why we moved to a new repo, see issue #11075) |
Before submitting a pull request, please make sure the following is done...
master
.npm test
).npm run lint
) - we've done our best to make sure these rules match our internal linting guidelines.