Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass event obj to the method #8668

Closed
wants to merge 2 commits into from
Closed

Pass event obj to the method #8668

wants to merge 2 commits into from

Conversation

mitenka
Copy link
Contributor

@mitenka mitenka commented Jan 1, 2017

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.
  6. If you haven't already, complete the CLA.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@aweary
Copy link
Contributor

aweary commented Jan 3, 2017

Thanks for the PR @mitenka! I think the change is good (as it demonstrates the argument is passed on the the class method), but it feels weird not actually using it. Can you think of a way we can update the example so it actually uses the e argument? (maybe logging out e.target.value along with this)?

@gaearon
Copy link
Collaborator

gaearon commented Jan 4, 2017

Let's not add "needs merge to stable" until we merge to master? Otherwise it's easy to accidentally get it merged before it's approved.

@aweary
Copy link
Contributor

aweary commented Jan 4, 2017

My bad, I usually add labels after merge, guess it's a habit adding both at once

@mitenka
Copy link
Contributor Author

mitenka commented Jan 7, 2017

@aweary, maybe it would be better to remove e argument from this.handleClick(e) calling in the arrow function?

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@kkemple
Copy link

kkemple commented Mar 20, 2017

@aweary is there any more work to do on this, or is this just in need of review?

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

Thank you for submitting this PR! 😄

Unfortunately the documentation and source code for reactjs.org has been moved to a different repository: https://github.com/reactjs/reactjs.org

If you are willing, please open a new PR there. Sorry for the inconvenience!

(For more backstory on why we moved to a new repo, see issue #11075)

@bvaughn bvaughn closed this Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants