[Fiber] Fix findDOMNode and findAllInRenderedTree #8450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is failing in Fiber without the fix. Because we have no deletions to rely on in this case and the placement effects have already happened.
sebmarkbage
force-pushed
the
fiberfinddomnode
branch
from
ffba29a
to
64262b9
Compare
|
Ok added tests. Done. |
This strategy finds the current fiber. It traverses back up to the root if the two trees are completely separate and determines which one is current. If the two trees converge anywhere along the way, we assume that is the current tree. We find the current child by searching the converged child set. This could fail if there's any way for both return pointers to point backwards to the work in progress. I don't think there is but I could be wrong. This may also fail on coroutines where we have reparenting situations.
sebmarkbage
force-pushed
the
fiberfinddomnode
branch
from
64262b9
to
a434f9e
Compare
sophiebits
approved these changes
Dec 3, 2016
| b = parentB; | ||
| invariant( | ||
| a.alternate === b, | ||
| 'Return fibers should always be each others\' alternates.' |
There was a problem hiding this comment.
other's (alternates of each other)
| 'Unable to find node on an unmounted component.' | ||
| ); | ||
| if (a.stateNode.current === a) { | ||
| // We've determined that A is the current branch. |
There was a problem hiding this comment.
I'm having trouble convincing myself why this is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strategy finds the current fiber. It traverses back up to the root if the two trees are completely separate and determines which one is current. If the two trees converge anywhere along the way, we assume that is the current tree. We find the current child by searching the converged child
set.
This could fail if there's any way for both return pointers to point backwards to the work in progress. I don't think there is but I could be wrong.
This may also fail on coroutines where we have reparenting situations.