Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for publishing a react component #8439

Closed
wants to merge 2 commits into from

Conversation

laumair
Copy link

@laumair laumair commented Nov 28, 2016

Related to: #7882 and #8060

@laumair
Copy link
Author

laumair commented Dec 6, 2016

@gaearon

@gaearon
Copy link
Collaborator

gaearon commented Jan 4, 2017

The style of the page doesn't look similar to how all the other doc pages are laid out. Can you please start by making it consistent with other doc pages?

@laumair
Copy link
Author

laumair commented Jan 6, 2017

@gaearon Sure thing

@laumair
Copy link
Author

laumair commented Jan 21, 2017

@gaearon I have made an attempt to make the style of page consistent with the other pages. Please let me know if there is any other thing that needs to be addressed. Thanks

@swyxio
Copy link
Contributor

swyxio commented Oct 6, 2017

reviving. how did documentation fail on circle ci? can this be merged?

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

Thank you for filing this PR!

I'm sorry to be the bearer of bad news, but the documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.)

Would you be willing to re-open this PR on the new repo? I promise we'll review it quickly!

@bvaughn bvaughn closed this Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants