Cleanup after #8353 #8403
Merged
Cleanup after #8353 #8403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
approved these changes
Nov 23, 2016
sophiebits
force-pushed
the
gh-8353-cleanup
branch
from
3310f2b
to
7af9af6
Compare
sebmarkbage
reviewed
Nov 23, 2016
| @@ -270,8 +270,6 @@ var ReactNoop = { | |||
|
|
|||
| syncUpdates: NoopRenderer.syncUpdates, | |||
|
|
|||
| isCommitting: () => isCommitting, | |||
|
|
|||
There was a problem hiding this comment.
You should probably just remove the the variable too.
There was a problem hiding this comment.
Oh I figured the invariant was useful.
sophiebits
force-pushed
the
gh-8353-cleanup
branch
from
7af9af6
to
8d3635a
Compare
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.