Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typechecking-with-proptypes.md #8313

Closed
wants to merge 1 commit into from

Conversation

stinoga
Copy link

@stinoga stinoga commented Nov 16, 2016

Shouldn't children's PropType be a node? Here's a good conversation on it in the eslint-plugin-react repo.

Shouldn't children's PropType be a `node`?
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Jan 4, 2017

Thanks for PR! I think it's a bit ambiguous so I'd leave it as is. For example you might want .element if you need a single element. Such as if you use cloneElement() there or if you return it without a wrapping <div> in some cases.

@gaearon gaearon closed this Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants