[Fiber] WIP context #8216
Closed
[Fiber] WIP context #8216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvinerikson
force-pushed
the
fiber-context
branch
from
578a651
to
1919236
Compare
edvinerikson
added
GH Review: needs-revision
and removed
GH Review: review-needed
labels
|
I'd like to explore a zero cost solution of context. The current way we do context is too expensive when you're not using it. We have a different strategy in mind that I think @gaearon might be looking at atm. |
|
Alright, sounds reasonable. Looking forward to see a different approach. Since you are working on this internally is there something else that I might be able to work on? |
|
@edvinerikson If you look at Phase 5 of #7925 there are a few issues there that are unclaimed that would be very helpful. You can also look for unit tests that aren't covered by the other ones issue. |
|
Thanks! I'll take a look, some of them are just magic for me 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently trying to get familiar with the Fiber codebase and IMO the best way to get up to speed is to work with the code.
So I started working on adding context support and got some tests passing for it however I am not sure if this is a good approach and I would appreciate some feedback on the work. All flows are not implemented yet.
I am not sure if I should utilize the Fiber more, right now I have
childContextthere which seems to break the pattern withmemoizedandpending. e.g maybechildContextcould be renamed tomemoizedChildContextbut I am not sure what pending would be. Feedback would be helpful.