Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jest to 16 #7948

Closed
wants to merge 2 commits into from
Closed

Bump Jest to 16 #7948

wants to merge 2 commits into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 12, 2016

This just updates Jest.

@quantizor
Copy link
Contributor

quantizor commented Oct 28, 2016

You could add a cacheDirectory entry as well to keep rebuilds speedy on CI. Otherwise, coverage runs can take quite a while.

"jest": {
  "cacheDirectory": "node_modules/.jest_cache"
}

Or something like that, and make sure node_modules are cached by Travis if they aren't already looks like they are.

@aweary
Copy link
Contributor

aweary commented Nov 5, 2016

@gaearon any blockers for this?

@quantizor
Copy link
Contributor

quantizor commented Nov 5, 2016

I personally would not merge until the Babel transform and object printing issues are resolved. jestjs/jest#1922 and jestjs/jest#1772 specifically.

@quantizor
Copy link
Contributor

Alrighty, now that the depth limiting change is in, I'd switch to [email protected] and this should be good to go.

@quantizor
Copy link
Contributor

I'd be happy to do both things if you want @gaearon?

I can do it tonight and send a PR.

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 17, 2016

Please do!

@gaearon gaearon closed this Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants