Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Add Facebook Open Source footer. #7871

Merged
merged 7 commits into from
Oct 6, 2016
Merged

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Oct 4, 2016

Replace the old footer with the one we have adopted in the GraphQL and React Native websites, for consistency.

I'd like to get two review passes on this:

  • one technical pass in terms of integration into the existing codebase, and
  • one content pass to cover what links should be included and under which sections.

We'll likely need to come back to this and update the links as we expand the docs.

Preview (page content ommitted for clarity):
screencapture-127-0-0-1-4000-react-index-html-1475615476564

@lacker
Copy link
Contributor

lacker commented Oct 4, 2016

Is this compatible with #7870 ?

@lacker
Copy link
Contributor

lacker commented Oct 4, 2016

For content, I think this is OK for now, but I also think we should revisit the links once we actually have all the new docs written. The technical integration seems good to me too, as long as we make sure something sane happens on mobile.

@hramos
Copy link
Contributor Author

hramos commented Oct 4, 2016

This PR is not currently compatible but it shouldn't be too much trouble to update my CSS to use #7870's mobile-friendly changes.

@vjeux
Copy link
Contributor

vjeux commented Oct 4, 2016

Great initiative for the footer :)

@hramos
Copy link
Contributor Author

hramos commented Oct 6, 2016

#7870 has been merged, and mobile changes have been taken into account in this PR.

@lacker lacker merged commit e4f90c9 into facebook:new-docs Oct 6, 2016
@hramos hramos deleted the footer branch October 11, 2016 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants