Remove unnecessary indirection and events from the hooks #7464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
gaearon
changed the title
| @@ -384,6 +384,7 @@ var NoopInternalComponent = function(element) { | |||
| this._renderedOutput = element; | |||
| this._currentElement = element; | |||
| this._debugID = nextDebugID++; | |||
| ReactInstrumentation.debugTool.onInstantiateComponent(this._debugID, element); | |||
There was a problem hiding this comment.
This might also resolve some issues we saw regarding missing elements in stacks
There was a problem hiding this comment.
I'm thinking #7240 (comment) and further reports. But not sure if that was related or not.
Less events is better. onSetDisplayName, onSetOwner, and onSetText only existed because we didn't initially track elements.
| onSetText(id, text) { | ||
| update(id, item => item.text = text); | ||
| onInstantiateComponent(id, element) { | ||
| create(id, element); |
There was a problem hiding this comment.
This is now the only place where we create entries. All others have been changed to vanilla get.
|
This is excellent. I love the create/get separation. |
zpao
pushed a commit
that referenced
this pull request
Aug 12, 2016
* Remove unnecessary indirection from the tree hook * Replace onSetDisplayName, onSetOwner, onSetText with one event Less events is better. onSetDisplayName, onSetOwner, and onSetText only existed because we didn't initially track elements. * Remove unused variables (cherry picked from commit 1f31357)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some additional DEV regressions.
This does two things:
onSetOwner,onSetDisplayNameandonSetTextwith one eventWe can do this now easily because we track elements.
This gives me 1.5x improvements in both mounting and unmounting time in DEV.
I tested with https://github.com/gaearon/js-framework-benchmark/tree/master/react-v15.3.0.