-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Object.is for checking mutated children #7436
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Of course, I'd like to found all other usages and replace with this lib as well, like it happens with |
except NaN, is there another case where it's useful? |
This also doesn't differ |
Can't this be a polyfill since |
We can discuss that separately. Right now we haven't required the polyfill exist in the other places it's used so we won't start now. |
I think this is not actual, because #7455 removes this code at all. Also, now |
fixes #7424