Code

Allow custom attributes by default#7311

Code

Closed

nhunzaker wants to merge 22 commits intofacebook:masterfacebook/react:masterfrom nhunzaker:nh-strip-whitelistnhunzaker/react:nh-strip-whitelistCopy head branch name to clipboard

+365-187

Commits

Commits on Aug 4, 2017

• Allow custom attributes. Add flag to toggle custom attribute behavior

  nhunzaker

  committed
  afae07c

  Copy full SHA for afae07c

• Update custom attribute logic

  Show description for 3388f4f
  nhunzaker

  committed
  3388f4f

  Copy full SHA for 3388f4f

• Allow numbers and booleans custom attributes. Cut isCustomAttribute

  nhunzaker

  committed
  9f7a696

  Copy full SHA for 9f7a696

• Cover objects with custom attributes in warning test

  nhunzaker

  committed
  fd94756

  Copy full SHA for fd94756

• Rename DOMProperty.isWriteable to shouldSetAttribute

  nhunzaker

  committed
  f870980

  Copy full SHA for f870980

• Rework conditions in shouldSetProperty to avoid edge cases

  nhunzaker

  committed
  ab64ef3

  Copy full SHA for ab64ef3

• Update unknown property warning to include custom attribute information

  nhunzaker

  committed
  7717ed7

  Copy full SHA for 7717ed7

• Remove ref and key from reserved props

  nhunzaker

  committed
  2b402a4

  Copy full SHA for 2b402a4

• Ensure SSR test coverage for DOMProperty injections

  nhunzaker

  committed
  1681e7f

  Copy full SHA for 1681e7f

• Add ajaxify attribute for internal FB support

  nhunzaker

  committed
  b5736c7

  Copy full SHA for b5736c7

• Ajaxify is a stringifiable object attribute

  nhunzaker

  committed
  976ca82

  Copy full SHA for 976ca82

• Update test name for custom attributes on custom elements

  nhunzaker

  committed
  17d3c49

  Copy full SHA for 17d3c49

• Remove SSR custom injection test

  nhunzaker

  committed
  40dee5a

  Copy full SHA for 40dee5a

• Remove onAfterResetModules hooks in SSR render tests

  nhunzaker

  committed
  b26384d

  Copy full SHA for b26384d

• Do not allow assignment of attributes that are aliased

  nhunzaker

  committed
  d672771

  Copy full SHA for d672771

• Update custom attribute test to check value, not just presence

  nhunzaker

  committed
  a871d55

  Copy full SHA for a871d55

• Address case where class is assigned as an attribute on custom elements. Improve SSR tests

  nhunzaker

  committed
  c748e84

  Copy full SHA for c748e84

• Cover cases where className and for are given to custom elements

  nhunzaker

  committed
  16dd18a

  Copy full SHA for 16dd18a

Commits on Aug 5, 2017

• Remove unnecessary spys on console.error. Reduce extra space in tests

  nhunzaker

  committed
  e68bf4d

  Copy full SHA for e68bf4d

• Cover cased custom attributes in SSR tests

  nhunzaker

  committed
  83e46aa

  Copy full SHA for 83e46aa

• Custom attributes are case sensitive

  nhunzaker

  committed
  facfa87

  Copy full SHA for facfa87

Commits on Aug 7, 2017

• Allow uppercase letters in custom attributes. Address associated edge cases

  nhunzaker

  committed
  82e05e0

  Copy full SHA for 82e05e0