Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues introduced by createElement() warning #6880

Merged
merged 10 commits into from
May 26, 2016
Merged

Fix issues introduced by createElement() warning #6880

merged 10 commits into from
May 26, 2016

Commits on May 25, 2016

  1. Do not clone key and ref getters

    @ericmatthys @gaearon
    ericmatthys authored and gaearon committed May 25, 2016
    Configuration menu
    Copy the full SHA
    94d0dc6 View commit details
    Browse the repository at this point in the history

  2. Remove indirection when determining valid config and ref

    @gaearon
    gaearon committed May 25, 2016
    Configuration menu
    Copy the full SHA
    f846edc View commit details
    Browse the repository at this point in the history

  3. Tweak whitespace

    @gaearon
    gaearon committed May 25, 2016
    Configuration menu
    Copy the full SHA
    15cd66b View commit details
    Browse the repository at this point in the history

  4. Add a test verifying undefined key and ref are ignored 

    It currently fails in `createElement` because of #6879 which was introduced in #5744.
It also fails in `cloneElement` because the code with that bug was extracted and shared in 94d0dc6.
    @gaearon
    gaearon committed May 25, 2016
    Configuration menu
    Copy the full SHA
    1b802fb View commit details
    Browse the repository at this point in the history

  5. Short-circuit the check just for getters 

    This way in other cases both DEV and PROD falls through to the check for undefined.
This fixes #6879 and a similar bug introduced for cloneElement() in 94d0dc6.
    @gaearon
    gaearon committed May 25, 2016
    Configuration menu
    Copy the full SHA
    c77411b View commit details
    Browse the repository at this point in the history

  6. Move tests concerned with cloning into ReactElementClone-test

    @gaearon
    gaearon committed May 25, 2016
    Configuration menu
    Copy the full SHA
    d9ae319 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2016

  1. Ignore specifically React warning getter in ReactElement 

    We don’t want to have different behavior in development and production.
Previously, we used to ignore getters on key/ref in dev, but we’d read them in prod.
Now, we only ignore the getters that we *know* we created so the production logic doesn’t differ.
    @gaearon
    gaearon committed May 26, 2016
    Configuration menu
    Copy the full SHA
    a432afa View commit details
    Browse the repository at this point in the history

  2. Correctly check that element and props are frozen 

    This fixes an incorrect way of checking introduced in 95373ce (it had no effect).
    @gaearon
    gaearon committed May 26, 2016
    Configuration menu
    Copy the full SHA
    919eba3 View commit details
    Browse the repository at this point in the history

  3. Infer displayName in more cases for props.ref/key warning

    @gaearon
    gaearon committed May 26, 2016
    Configuration menu
    Copy the full SHA
    55a0e4b View commit details
    Browse the repository at this point in the history

  4. Inline expectations in tests as they are used once

    @gaearon
    gaearon committed May 26, 2016
    Configuration menu
    Copy the full SHA
    58c9fda View commit details
    Browse the repository at this point in the history