Fix NPE during reconciliation #6028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactDOMSelect's _handleChange function tries to set this._wrapperState.pendingUpdate = true after executing the onChange function. However, if the select was removed as a result of said fuction, this._wrapperState would be null. Resulting in an Uncaught TypeError: Cannot set property 'pendingUpdate' of null.
| @@ -236,7 +236,9 @@ function _handleChange(event) { | |||
| var props = this._currentElement.props; | |||
| var returnValue = LinkedValueUtils.executeOnChange(props, event); | |||
|
|
|||
| this._wrapperState.pendingUpdate = true; | |||
| if (this._rootNodeID && !this._wrapperState.pendingUpdate) { | |||
There was a problem hiding this comment.
This seems reasonable to me. We don't need to check the value of pendingUpdate, we can just blindly set it to true. Can you update the PR to remove that check?
We can just set it to true regardless.
| @@ -236,7 +236,9 @@ function _handleChange(event) { | |||
| var props = this._currentElement.props; | |||
| var returnValue = LinkedValueUtils.executeOnChange(props, event); | |||
|
|
|||
| this._wrapperState.pendingUpdate = true; | |||
| if (this._rootNodeID) { | |||
There was a problem hiding this comment.
@jimfb Removed check for pendingUpdate. Let me know if there is anything else, or I misunderstood. Thanks!
|
@sambev updated the pull request. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactDOMSelect's _handleChange function tries to set
this._wrapperState.pendingUpdate = true after executing the onChange
function. However, if the select was removed as a result of said
fuction, this._wrapperState would be null. Resulting in an
Uncaught TypeError: Cannot set property 'pendingUpdate' of null.
#6027