Updating "JSX Gotchas" docs for Custom Attributes #5231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds note that custom attributes are supported on custom elements.
|
This seems good to me. Thanks! cc @jimfb for a quick sanity check |
|
Looks good to me, thanks @davidkpiano! |
jimfb
added a commit
that referenced
this pull request
Nov 5, 2015
Updating "JSX Gotchas" docs for Custom Attributes
jimfb
added a commit
that referenced
this pull request
Nov 10, 2015
Updating "JSX Gotchas" docs for Custom Attributes (cherry picked from commit 22b8952)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds note that custom attributes are supported on custom elements.
Based on this change in 0.14.x: #3067