Fail tests on any un-spied warnings #4223
Merged
+60
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
force-pushed
the
check-no-warn
branch
from
44098ca to
1b4aeff
Compare
|
|
||
| expect(() => React.render(React.createElement(Empty), container)).toThrow(); | ||
|
|
||
| expect(warn.mock.calls.length).toBe(1); | ||
| expect(warn.mock.calls[0][0]).toBe( | ||
| expect((<any>console.error).argsForCall.length).toBe(1); |
There was a problem hiding this comment.
Do we need to typecast this to make TypeScript happy?
sophiebits
force-pushed
the
check-no-warn
branch
from
1b4aeff to
c22153e
Compare
sophiebits
added a commit
that referenced
this pull request
Jun 29, 2015
Fail tests on any un-spied warnings
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Sep 30, 2015
Originally facebook#4223 -- we lost this when we switched to jest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3890. Fixed existing tests to all set
console.errorback to its original value when they're done by making them use spyOn.