Adding validation for array in ReactPropTypes. #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For anybody following along at home, this is a re-submit of #3807. Sorry you had issues rebasing, but I appreciate the work, thanks! |
zpao
added a commit
that referenced
this pull request
May 26, 2015
Adding validation for array in ReactPropTypes.
|
Thanks @zpao, I apologize for the back-and-forth on this PR. At least, now I've learned how to properly do it. |
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
May 27, 2015
Follow-up to facebook#3963. (Returning an Error wasn't useful; it just caused a later error when actually using it because type checkers need to be functions.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had people on my team sending wrong arguments to oneOf and oneOfType attributes from PropTypes.
The current message exposed some internal attributes to the user with the following message:
This warning is a little misleading, I had to spend some time trying to figure out who was invoking this checker function, unsuccessfully. Then, after some time, I realized the argument to oneOf and oneOfType was actually invalid and it had nothing to do with checker function.
I've opened a StackOverflow case for this.
This pull request aims to fix this problem by validating the argument type as an array in both createUnionTypeChecker and createEnumTypeChecker. I've added the corresponding tests for this.
Alan