Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 16, 2026

We no longer set the following globals since they're not read by DevTools. It also doesn't look like they had any meaningful values anymore which was hidden by missing Flow coverage.

  • __REACT_DEVTOOLS_APPEND_COMPONENT_STACK__
  • __REACT_DEVTOOLS_BREAK_ON_CONSOLE_ERRORS__
  • __REACT_DEVTOOLS_SHOW_INLINE_WARNINGS_AND_ERRORS__
  • __REACT_DEVTOOLS_HIDE_CONSOLE_LOGS_IN_STRICT_MODE__
  • __REACT_DEVTOOLS_DISABLE_SECOND_CONSOLE_LOG_DIMMING_IN_STRICT_MODE__

__REACT_DEVTOOLS_COMPONENT_FILTERS__ is still set since it's still in use (although not fully functional in the browser extension which I intend to fix).

@meta-cla meta-cla bot added the CLA Signed label Jan 16, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jan 16, 2026
@eps1lon eps1lon force-pushed the sebbie/01-16-_devtools_stop_setting_unused_global_variables branch from c8122cc to 3d6180c Compare January 16, 2026 12:09
@eps1lon eps1lon requested a review from hoxyq January 16, 2026 12:17
@eps1lon eps1lon marked this pull request as ready for review January 16, 2026 12:17
@eps1lon eps1lon merged commit bef88f7 into facebook:main Jan 16, 2026
237 checks passed
@eps1lon eps1lon deleted the sebbie/01-16-_devtools_stop_setting_unused_global_variables branch January 16, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants