Skip to content

[DevTools] Show fallback in inspected element pane when no element is selected #35503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 3 commits into from
Jan 15, 2026
+24 −4
Merged

[DevTools] Show fallback in inspected element pane when no element is selected #35503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63a70d6
[DevTools] Show fallback in inspected element pane when no element is…
eps1lon Jan 13, 2026
a144f2d
Remove redundant borders
eps1lon Jan 13, 2026
f261518
Improve fallback copy
eps1lon Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-devtools-shared/src/devtools/views/Components/Components.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
flex: 1 1 35%;
overflow-x: hidden;
overflow-y: auto;
border-left: 1px solid var(--color-border);
}

.ResizeBarWrapper {
Expand Down Expand Up @@ -55,6 +56,7 @@

.InspectedElementWrapper {
flex: 1 1 50%;
border-left: none;
}

.ResizeBar {
Expand Down
6 changes: 5 additions & 1 deletion packages/react-devtools-shared/src/devtools/views/Components/Components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,11 @@ function Components(_: {}) {
<div className={styles.InspectedElementWrapper}>
<NativeStyleContextController>
<InspectedElementErrorBoundary>
<InspectedElement />
<InspectedElement
fallbackEmpty={
'No React element selected. Select an element in the tree to inspect.'
}
/>
</InspectedElementErrorBoundary>
</NativeStyleContextController>
</div>
Expand Down
7 changes: 5 additions & 2 deletions packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
flex-direction: column;
height: 100%;
width: 100%;
border-left: 1px solid var(--color-border);
border-top: 1px solid var(--color-border);
}

Expand Down Expand Up @@ -69,7 +68,11 @@
padding: 0.25rem;
color: var(--color-dimmer);
font-style: italic;
border-left: 1px solid var(--color-border);
Copy link
Collaborator Author

@eps1lon eps1lon Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placing the border here made the border only span a single line. Now the border is one the whole container while also not being duplicated if the parent already defines a border. This makes composition easier with regards to border drawing.

}

.NoInspectionFallback {
padding: 0.25rem;
font-style: italic;
}

.StrictModeNonCompliant {
Expand Down
4 changes: 4 additions & 0 deletions packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ import Tooltip from './reach-ui/tooltip';

export type Props = {
actionButtons?: React.Node,
/** fallback to show when no element is inspected */
fallbackEmpty: React.Node,
};

// TODO Make edits and deletes also use transition API!
Expand All @@ -44,6 +46,7 @@ const noSourcePromise = Promise.resolve(null);

export default function InspectedElementWrapper({
actionButtons,
fallbackEmpty,
}: Props): React.Node {
const {inspectedElementID} = useContext(TreeStateContext);
const bridge = useContext(BridgeContext);
Expand Down Expand Up @@ -193,6 +196,7 @@ export default function InspectedElementWrapper({
return (
<div className={styles.InspectedElement}>
<div className={styles.TitleRow} />
<div className={styles.NoInspectionFallback}>{fallbackEmpty}</div>
Copy link
Collaborator Author

@eps1lon eps1lon Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also show the loading fallback below the title row.

</div>
);
}
Expand Down
1 change: 1 addition & 0 deletions packages/react-devtools-shared/src/devtools/views/InspectedElement/InspectedElementPane.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ function InspectedElementPane() {
<div className={styles.InspectedElementPane}>
<InspectedElement
actionButtons={!hideSettings && <SettingsModalContextToggle />}
fallbackEmpty={"Selected element wasn't rendered with React."}
/>
<SettingsModal />
</div>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTab.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
flex: 0 0 calc(100% - var(--horizontal-resize-tree-percentage));
overflow-x: hidden;
overflow-y: auto;
border-left: 1px solid var(--color-border);
}

.ResizeBarWrapper {
Expand Down Expand Up @@ -70,6 +71,7 @@

.InspectedElementWrapper {
flex: 0 0 calc(100% - var(--vertical-resize-tree-percentage));
border-left: none;
}

.TreeWrapper + .ResizeBarWrapper .ResizeBar {
Expand Down
6 changes: 5 additions & 1 deletion packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,11 @@ function SuspenseTab(_: {}) {
className={styles.InspectedElementWrapper}
hidden={inspectedElementHidden}>
<InspectedElementErrorBoundary>
<InspectedElement />
<InspectedElement
fallbackEmpty={
'No React element selected. Select a Suspense boundary in the minimap to inspect.'
}
/>
</InspectedElementErrorBoundary>
</div>
<SettingsModal />
Expand Down
Loading