[DevTools] Batch updates when updating component filters #35093
Merged
+4
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #35107
We used to flush operations between unmounting each root and remounting each root. This could lead to focus or selection loss when the focused/selected element was temporarily removed while we were mounting the root again in the backend. Notably when keyboard navigating through the Activity list and focusing on a specific Activity. We'd flush after each root was unmounted leading to an unnmount of the Activity list since no more named Activities existed.
Looks like a leftover from when flushing operations was tied to a root. If this leads to crashes due to operations sent being too large, we should implement some streaming approach where the frontend can decide if it wants to flush between each chunk (operations for one root) or at the end.
Alternatively we could also flush after processing each root when processing unmount+mount i.e.
instead of