[Flight] Fix wrong missing key warning when static child is blocked #34350
+105
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
unstubbable
force-pushed
the
fix-missing-key-warning
branch
from
29d2350 to
c4db503
Compare
unstubbable
force-pushed
the
fix-missing-key-warning
branch
from
c4db503 to
60ae1c4
Compare
This comment has been minimized.
This comment has been minimized.
eps1lon
approved these changes
Sep 1, 2025
unstubbable
added a commit
to unstubbable/react
that referenced
this pull request
Sep 1, 2025
Small follow-up to facebook#34350. The `_store` property is now only assigned in development mode when creating lazy types. It also uses the `validated` value that was passed to `createElement`, if applicable.
|
Doesn't make sense to me that a Lazy node would even get validated. It can't have a key and so there's nothing to validate. It should also never drill into assuming the data structure of Lazy in React code. The validation should drill into the child like what |
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 4, 2025
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 4, 2025
…acebook#34354) Small follow-up to facebook#34350. The `_store` property is now only assigned in development mode when creating lazy types. It also uses the `validated` value that was passed to `createElement`, if applicable.
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a static JSX child in a client component is blocked, e.g. on debug info, we must ensure that the key validation that's done by the JSX runtime also handles lazy types. Otherwise, a false-positive missing key warning is printed.