[DevTools] Make a non-editable name of KeyValue clickable #34095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
force-pushed
the
devtoolsclickkeyvalue
branch
from
dd2d7c0 to
20e7949
Compare
hoxyq
approved these changes
Aug 4, 2025
eps1lon
approved these changes
Aug 4, 2025
Collaborator
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
I suspect this was intentional for text-selection. Now it behaves like <details>. But just a tiny chevron for the toggle is worse.
Collaborator
Author
|
Yea it's annoying that it opens and closes if you try to copy the attribute name but at least of the common case of opening and closing it doesn't drop clicks. |
eps1lon
pushed a commit
to eps1lon/react
that referenced
this pull request
Aug 4, 2025
…4095) This has been bothering me. You can click the arrow and the value to expand/collapse a KeyValue row but not the name. When the name is not editable it should be clickable. Such as when inspecting a Promise value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been bothering me. You can click the arrow and the value to expand/collapse a KeyValue row but not the name.
When the name is not editable it should be clickable. Such as when inspecting a Promise value.