-
Notifications
You must be signed in to change notification settings - Fork 49.9k
[DevTools] Layout for Suspense tab #34042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+620
−4
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTab.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| .SuspenseTab { | ||
| position: relative; | ||
| width: 100%; | ||
| height: 100%; | ||
| display: flex; | ||
| flex-direction: row; | ||
| background-color: var(--color-background); | ||
| color: var(--color-text); | ||
| font-family: var(--font-family-sans); | ||
| } | ||
|
|
||
| .SuspenseTab, .SuspenseTab * { | ||
| box-sizing: border-box; | ||
| -webkit-font-smoothing: var(--font-smoothing); | ||
| } | ||
|
|
||
| .TreeWrapper { | ||
| flex: 1 1 var(--horizontal-resize-tree-percentage); | ||
| display: flex; | ||
| flex-direction: row; | ||
| overflow: auto; | ||
| border-top: 1px solid var(--color-border); | ||
| } | ||
|
|
||
| .InspectedElementWrapper { | ||
| flex: 1 1 calc(100% - var(--horizontal-resize-tree-percentage)); | ||
| overflow-x: hidden; | ||
| overflow-y: auto; | ||
| } | ||
|
|
||
| .ResizeBarWrapper { | ||
| flex: 0 0 0px; | ||
| position: relative; | ||
| } | ||
|
|
||
| .ResizeBar { | ||
| position: absolute; | ||
| /* | ||
| * moving the bar out of its bounding box might cause its hitbox to overlap | ||
| * with another scrollbar creating disorienting UX where you both resize and scroll | ||
| * at the same time. | ||
| * If you adjust this value, double check that starting resize right on this edge | ||
| * doesn't also cause scroll | ||
| */ | ||
| left: 1px; | ||
| width: 5px; | ||
| height: 100%; | ||
| cursor: ew-resize; | ||
| } | ||
|
|
||
| .TreeView footer { | ||
| display: none; | ||
| } | ||
|
|
||
|
|
||
|
|
||
| @container devtools (width < 600px) { | ||
| .SuspenseTab { | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| .TreeWrapper { | ||
| border-top: 1px solid var(--color-border); | ||
| flex: 1 0 var(--vertical-resize-tree-percentage); | ||
| } | ||
|
|
||
| .InspectedElementWrapper { | ||
| flex: 1 1 50%; | ||
| } | ||
|
|
||
| .TreeWrapper + .ResizeBarWrapper .ResizeBar { | ||
| top: 1px; | ||
| left: 0; | ||
| width: 100%; | ||
| height: 5px; | ||
| cursor: ns-resize; | ||
| } | ||
|
|
||
| .TreeView footer { | ||
| display: flex; | ||
| justify-content: end; | ||
| } | ||
|
|
||
| .ToggleInspectedElement[data-orientation="horizontal"] { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| .TreeList { | ||
| flex: 0 0 var(--horizontal-resize-tree-list-percentage); | ||
| border-right: 1px solid var(--color-border); | ||
| padding: 0.25rem | ||
| } | ||
|
|
||
| .TreeView { | ||
| flex: 1 1 35%; | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
|
|
||
|
|
||
| .Rects { | ||
| border-top: 1px solid var(--color-border); | ||
| padding: 0.25rem; | ||
| flex-grow: 1; | ||
| } | ||
|
|
||
| .TimelineWrapper { | ||
| padding: 0.25rem; | ||
| display: flex; | ||
| flex-direction: row; | ||
| } | ||
|
|
||
| .Timeline { | ||
| flex-grow: 1; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just the default https://fonts.google.com/icons comes with. You can scale the paths to adhere to the default viewbox but I couldn't find a tool for that quickly and none of the LLMs produced a result I could use.
The Material icons are the ones Chrome is using for the sidebar toggles.
They're license under Apache 2: https://developers.google.com/fonts/docs/material_icons#licensing