[compiler] Show logged errors in playground #33740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
poteto
approved these changes
Jul 9, 2025
| logEvent: () => {}, | ||
| logEvent: (_filename: string | null, event: LoggerEvent) => { | ||
| if (event.kind === 'CompileError') { | ||
| error.details.push(new CompilerErrorDetail(event.detail)); |
Member
There was a problem hiding this comment.
We might need to dedupe this, I noticed that some errors are shown twice: https://react-compiler-playground-m6niqasen-fbopensource.vercel.app/#N4Igzg9grgTgxgUxALhAejQAgAIDcCGANgJYAm+ALggHIQDKCFdFlCAkgHYAK+YYxuBAFEAZiIRwKYHCMIQA7gB0OIqB0nEIHTFDAIAYhAgAKAJSZgyzJjhawFTAG17rADSY9TFlQC6mALw6esysxo4+pgDcVpgUMACeFpgAvjFwlHAAFkmp2pgixBxEhInAKTG6wmISFMZmAQB8FjHWniFUxnFQCFExyabKySDJQA
Member
Author
There was a problem hiding this comment.
ohhh good catch. i really want to overhaul the error reporting system to avoid this by design
In playground it's helpful to show all errors, even those that don't completely abort compilation. For example, to help demonstrate that the compiler catches things like setState in effects. This detects these errors and ensures we show them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In playground it's helpful to show all errors, even those that don't completely abort compilation. For example, to help demonstrate that the compiler catches things like setState in effects. This detects these errors and ensures we show them.