Skip to content

[not for merge] Check if Flight fixture smoke tests use correct build #33425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+4 −2
Closed

[not for merge] Check if Flight fixture smoke tests use correct build #33425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fixtures/flight/playwright.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ export default defineConfig({
retries: isCI ? 2 : 0,
// Opt out of parallel tests on CI.
workers: isCI ? 1 : undefined,
reporter: 'html',
reporter: [['html'], ['list', {printSteps: true}]],
use: {
baseURL: 'http://localhost:3000',

trace: 'on-first-retry',
trace: 'on',
},
projects: [
{
Expand Down
2 changes: 2 additions & 0 deletions packages/react-server-dom-webpack/src/ReactFlightWebpackNodeRegister.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@

const Module = require('module');

throw new Error('testing')

module.exports = function register() {

Check failure on line 18 in packages/react-server-dom-webpack/src/ReactFlightWebpackNodeRegister.js

View workflow job for this annotation

GitHub Actions / Run eslint 

Unreachable code
const Server: any = require('react-server-dom-webpack/server');
const registerServerReference = Server.registerServerReference;
const createClientModuleProxy = Server.createClientModuleProxy;
Expand Down
Loading