Skip to content

Conversation

@michaelfaith
Copy link
Contributor

@michaelfaith michaelfaith commented Feb 16, 2025

This change adds a workflow for PR builds, that runs the e2e tests for eslint-plugin-react-hooks created in #32396

screenshot of ci tests running

@react-sizebot
Copy link

react-sizebot commented Feb 16, 2025

Comparing: be91130...0f5da2b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.71 kB 515.71 kB = 92.09 kB 92.09 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 562.25 kB 562.25 kB = 100.08 kB 100.08 kB
facebook-www/ReactDOM-prod.classic.js = 636.70 kB 636.70 kB = 112.08 kB 112.08 kB
facebook-www/ReactDOM-prod.modern.js = 627.02 kB 627.02 kB = 110.49 kB 110.49 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.75 kB 94.56 kB = 22.57 kB 15.31 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.57 kB 92.36 kB = 22.54 kB 15.05 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.57 kB 92.36 kB = 22.54 kB 15.05 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.66 kB 84.44 kB = 22.52 kB 14.95 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.49 kB 82.49 kB = 22.50 kB 14.67 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.49 kB 82.49 kB = 22.50 kB 14.67 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.75 kB 94.56 kB = 22.57 kB 15.31 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.57 kB 92.36 kB = 22.54 kB 15.05 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 113.57 kB 92.36 kB = 22.54 kB 15.05 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.66 kB 84.44 kB = 22.52 kB 14.95 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.49 kB 82.49 kB = 22.50 kB 14.67 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 113.49 kB 82.49 kB = 22.50 kB 14.67 kB

Generated by 🚫 dangerJS against a61ea0c

This change adds a workflow for PR builds, that runs the e2e tests for `eslint-plugin-react-hooks` created in facebook#32396
@michaelfaith
Copy link
Contributor Author

Updated to address the feedback items

@poteto poteto merged commit eb1f77d into facebook:main Feb 16, 2025
194 checks passed
@michaelfaith michaelfaith deleted the ci/add-eslint-e2e-testing-to-ci branch February 16, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants