Skip to content

[compiler] Early sketch of ReactiveIR #31974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[compiler] Early sketch of ReactiveIR #31974

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8771138
[compiler] Early sketch of ReactiveIR
josephsavona Jan 4, 2025
0522415
Update on "[compiler] Early sketch of ReactiveIR"
josephsavona Jan 6, 2025
3f0031d
Update on "[compiler] Early sketch of ReactiveIR"
josephsavona Jan 6, 2025
9e1f36a
Update on "[compiler] Early sketch of ReactiveIR"
josephsavona Jan 6, 2025
4e104fc
Update on "[compiler] Early sketch of ReactiveIR"
josephsavona Jan 7, 2025
a5d0912
Update on "[compiler] Early sketch of ReactiveIR"
josephsavona Jan 8, 2025
5be650c
Update on "[compiler] Early sketch of ReactiveIR"
josephsavona Jan 8, 2025
52c360f
Update on "[compiler] Early sketch of ReactiveIR"
josephsavona Jan 8, 2025
3383816
Update on "[compiler] Early sketch of ReactiveIR"
josephsavona Jan 8, 2025
d09f026
Update on "[compiler] Early sketch of ReactiveIR"
josephsavona Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ import {propagateScopeDependenciesHIR} from '../HIR/PropagateScopeDependenciesHI
import {outlineJSX} from '../Optimization/OutlineJsx';
import {optimizePropsMethodCalls} from '../Optimization/OptimizePropsMethodCalls';
import {transformFire} from '../Transform';
import {buildReactiveGraph} from '../ReactiveIR/BuildReactiveGraph';
import {printReactiveGraph} from '../ReactiveIR/ReactiveIR';

export type CompilerPipelineValue =
| {kind: 'ast'; name: string; value: CodegenFunction}
Expand Down Expand Up @@ -314,6 +316,15 @@ function runWithEnvironment(
value: hir,
});

if (env.config.enableReactiveGraph) {
const reactiveGraph = buildReactiveGraph(hir);
log({
kind: 'debug',
name: 'BuildReactiveGraph',
value: printReactiveGraph(reactiveGraph),
});
}
Comment on lines +319 to +326
Copy link
Member Author

@josephsavona josephsavona Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that i'm experimenting with running this before constructing scope terminals, since that's where it would have to go in order to reorder to avoid unnecessary scope interleaving


alignReactiveScopesToBlockScopesHIR(hir);
log({
kind: 'hir',
Expand Down
6 changes: 6 additions & 0 deletions compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,12 @@ const EnvironmentConfigSchema = z.object({
*/
enableInstructionReordering: z.boolean().default(false),

/**
* Enables ReactiveGraph-based optimizations including reordering across terminal
* boundaries
*/
enableReactiveGraph: z.boolean().default(false),

/**
* Enables function outlinining, where anonymous functions that do not close over
* local variables can be extracted into top-level helper functions.
Expand Down
Loading
Loading