Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Reject any new Chunks not yet discovered at the time of reportGlobalError #31851

Merged
merged 3 commits into from
Dec 19, 2024
Merged

[Flight] Reject any new Chunks not yet discovered at the time of reportGlobalError #31851

merged 3 commits into from
Dec 19, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Same as #31840 but for the Flight Client.

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 4:56am

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 19, 2024
@react-sizebot
Copy link

react-sizebot commented Dec 19, 2024 •
edited
Loading

Comparing: 17520b6...c03b070

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 511.38 kB 511.38 kB = 91.38 kB 91.38 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 517.53 kB 517.53 kB = 92.34 kB 92.34 kB
facebook-www/ReactDOM-prod.classic.js = 593.09 kB 593.09 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 583.35 kB 583.35 kB = 102.90 kB 102.90 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js = 2.11 kB 2.05 kB = 0.79 kB 0.78 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js = 2.11 kB 2.05 kB = 0.79 kB 0.78 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js = 2.11 kB 2.05 kB = 0.79 kB 0.78 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.js = 1.84 kB 1.78 kB = 0.74 kB 0.73 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.js = 1.84 kB 1.78 kB = 0.74 kB 0.73 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.js = 1.84 kB 1.78 kB = 0.74 kB 0.73 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js +0.51% 50.48 kB 50.73 kB +0.54% 10.21 kB 10.26 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.50% 50.72 kB 50.98 kB +0.52% 10.34 kB 10.39 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.49% 52.63 kB 52.89 kB +0.48% 10.73 kB 10.78 kB
oss-experimental/react-client/cjs/react-client-flight.production.js +0.48% 57.38 kB 57.66 kB +0.54% 10.70 kB 10.75 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.48% 53.06 kB 53.32 kB +0.46% 10.83 kB 10.88 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +0.48% 53.26 kB 53.51 kB +0.53% 10.86 kB 10.92 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.47% 54.64 kB 54.89 kB +0.54% 11.18 kB 11.24 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js +0.47% 54.79 kB 55.05 kB +0.54% 11.17 kB 11.23 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.46% 81.65 kB 82.03 kB +0.48% 17.14 kB 17.22 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.46% 81.65 kB 82.03 kB +0.48% 17.14 kB 17.22 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.45% 82.39 kB 82.76 kB +0.48% 17.26 kB 17.34 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.45% 56.97 kB 57.22 kB +0.52% 11.64 kB 11.70 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js +0.44% 49.97 kB 50.19 kB +0.55% 10.12 kB 10.17 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js +0.44% 49.97 kB 50.19 kB +0.55% 10.12 kB 10.17 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.44% 58.46 kB 58.72 kB +0.50% 11.95 kB 12.01 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.44% 58.55 kB 58.80 kB +0.50% 11.97 kB 12.03 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.44% 50.21 kB 50.43 kB +0.46% 10.25 kB 10.29 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.44% 50.21 kB 50.43 kB +0.46% 10.25 kB 10.29 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.43% 59.46 kB 59.72 kB +0.51% 11.94 kB 12.00 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.42% 60.64 kB 60.89 kB +0.49% 12.17 kB 12.23 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.42% 52.12 kB 52.34 kB +0.43% 10.64 kB 10.68 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.42% 52.12 kB 52.34 kB +0.43% 10.64 kB 10.68 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.42% 52.55 kB 52.77 kB +0.45% 10.74 kB 10.79 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.42% 52.55 kB 52.77 kB +0.45% 10.74 kB 10.79 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +0.42% 52.75 kB 52.97 kB +0.46% 10.78 kB 10.83 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +0.42% 52.75 kB 52.97 kB +0.46% 10.78 kB 10.83 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.js +0.41% 56.94 kB 57.18 kB +0.40% 10.61 kB 10.65 kB
oss-stable/react-client/cjs/react-client-flight.production.js +0.41% 56.97 kB 57.20 kB +0.39% 10.63 kB 10.68 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.40% 54.13 kB 54.35 kB +0.46% 11.10 kB 11.15 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.40% 54.13 kB 54.35 kB +0.46% 11.10 kB 11.15 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js +0.40% 54.28 kB 54.50 kB +0.43% 11.09 kB 11.14 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js +0.40% 54.28 kB 54.50 kB +0.43% 11.09 kB 11.14 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.39% 56.46 kB 56.68 kB +0.40% 11.56 kB 11.61 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.39% 56.46 kB 56.68 kB +0.40% 11.56 kB 11.61 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.38% 57.95 kB 58.17 kB +0.44% 11.87 kB 11.92 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.38% 57.95 kB 58.17 kB +0.44% 11.87 kB 11.92 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.38% 58.04 kB 58.26 kB +0.44% 11.89 kB 11.95 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.38% 58.04 kB 58.26 kB +0.44% 11.89 kB 11.95 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.37% 58.97 kB 59.19 kB +0.43% 11.85 kB 11.90 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.37% 58.97 kB 59.19 kB +0.43% 11.85 kB 11.90 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.36% 60.15 kB 60.37 kB +0.41% 12.09 kB 12.14 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.36% 60.15 kB 60.37 kB +0.41% 12.09 kB 12.14 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.30% 123.04 kB 123.41 kB +0.32% 28.48 kB 28.57 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.30% 123.06 kB 123.44 kB +0.31% 28.51 kB 28.60 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +0.29% 87.82 kB 88.07 kB +0.31% 16.59 kB 16.64 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +0.29% 87.87 kB 88.12 kB +0.29% 16.62 kB 16.67 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.29% 87.94 kB 88.19 kB +0.33% 16.75 kB 16.80 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.29% 87.99 kB 88.24 kB +0.32% 16.77 kB 16.83 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +0.28% 89.29 kB 89.54 kB +0.28% 16.36 kB 16.40 kB
oss-stable/react-client/cjs/react-client-flight.development.js +0.28% 89.32 kB 89.57 kB +0.28% 16.38 kB 16.43 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +0.28% 90.04 kB 90.29 kB +0.32% 17.02 kB 17.07 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +0.28% 90.04 kB 90.29 kB +0.32% 17.02 kB 17.07 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.28% 90.13 kB 90.38 kB +0.32% 17.14 kB 17.19 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.28% 90.18 kB 90.43 kB +0.30% 17.16 kB 17.21 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.28% 90.68 kB 90.93 kB +0.31% 17.26 kB 17.32 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.28% 90.73 kB 90.98 kB +0.31% 17.29 kB 17.34 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.27% 91.65 kB 91.90 kB +0.29% 17.34 kB 17.39 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.27% 91.65 kB 91.90 kB +0.29% 17.34 kB 17.39 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +0.27% 91.84 kB 92.09 kB +0.30% 17.37 kB 17.42 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +0.27% 91.84 kB 92.09 kB +0.30% 17.37 kB 17.42 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.27% 94.29 kB 94.54 kB +0.29% 17.80 kB 17.85 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.27% 94.29 kB 94.54 kB +0.29% 17.80 kB 17.85 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.26% 96.03 kB 96.28 kB +0.29% 18.14 kB 18.19 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.26% 96.03 kB 96.28 kB +0.29% 18.14 kB 18.19 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.26% 96.12 kB 96.37 kB +0.28% 18.18 kB 18.23 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.26% 96.12 kB 96.37 kB +0.28% 18.18 kB 18.23 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.26% 143.20 kB 143.57 kB +0.24% 33.62 kB 33.70 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.26% 97.03 kB 97.28 kB +0.29% 18.07 kB 18.12 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.26% 97.03 kB 97.28 kB +0.29% 18.07 kB 18.12 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.26% 98.36 kB 98.61 kB +0.28% 18.33 kB 18.38 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.26% 98.36 kB 98.61 kB +0.28% 18.33 kB 18.38 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js = 2.11 kB 2.05 kB = 0.79 kB 0.78 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js = 2.11 kB 2.05 kB = 0.79 kB 0.78 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js = 2.11 kB 2.05 kB = 0.79 kB 0.78 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.js = 1.84 kB 1.78 kB = 0.74 kB 0.73 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.js = 1.84 kB 1.78 kB = 0.74 kB 0.73 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.js = 1.84 kB 1.78 kB = 0.74 kB 0.73 kB

Generated by 🚫 dangerJS against 1e9061f

@sebmarkbage
Never close NoopFlightClient
e333303 
We test streaming with this but we never actually test closing the stream.
@sebmarkbage
Update tests
1e9061f 
This bug is now fixed.
@sebmarkbage sebmarkbage merged commit a9bbe34 into facebook:main Dec 19, 2024
187 checks passed
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 19, 2024
@pull
[Flight] Reject any new Chunks not yet discovered at the time of repo…
6c71a5b 
…rtGlobalError (facebook#31851)

Same as facebook#31840 but for the Flight Client.

DiffTrain build for [a9bbe34](facebook@a9bbe34)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 19, 2024
@pull
[Flight] Reject any new Chunks not yet discovered at the time of repo…
71568c0 
…rtGlobalError (facebook#31851)

Same as facebook#31840 but for the Flight Client.

DiffTrain build for [a9bbe34](facebook@a9bbe34)
github-actions bot pushed a commit to AreaLayer/react that referenced this pull request Dec 19, 2024
@22388o
[Flight] Reject any new Chunks not yet discovered at the time of repo…
7e80393 
…rtGlobalError (facebook#31851)

Same as facebook#31840 but for the Flight Client.

DiffTrain build for [a9bbe34](facebook@a9bbe34)
github-actions bot pushed a commit to AreaLayer/react that referenced this pull request Dec 19, 2024
@22388o
[Flight] Reject any new Chunks not yet discovered at the time of repo…
fee13cf 
…rtGlobalError (facebook#31851)

Same as facebook#31840 but for the Flight Client.

DiffTrain build for [a9bbe34](facebook@a9bbe34)
This was referenced Dec 19, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff gnoff approved these changes

@unstubbable unstubbable Awaiting requested review from unstubbable

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @gnoff @facebook-github-bot