Ensure function arity is preserved after build #31808
Open
+113
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eps1lon
changed the title
eps1lon
reviewed
Dec 17, 2024
| message: | ||
| 'Google Closure Compiler optimized `arguments` access. ' + | ||
| 'This affects function arity. ' + | ||
| 'Access `arguments.length` to avoid this optimization', |
There was a problem hiding this comment.
We should update this. This advise does not work
|
Comparing: 34ee391...f229077 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31578
Closes #31598
Problem
The google closure compiler has a feature for optimizing function calls. It identifies opportunities to replace the original argument arrays with a more compact representation, such as array or replace constant arguments with their literal values.
In the case of functions that use
argumentsit added an extra parameter and caused the arity (fn.length) to differ (which became different from development to prod due to DEV).This became an issue for reason-react (and maybe other binding systems as well), since we need to bind to the interface and statically how many parameters are expected. reason-react carries the OCaml-way of being a curried language where there's no difference between
let fn = (a, b) => ...andlet fn = (a) => (b) => .... The compiler to JavaScript (Melange) has a small runtime that calls the function with the right number of parameters. This is the related issue: reasonml/reason-react#860.Solution
At first, I made it work with the
// @nocollapseannotation (https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#nocollapse), but I found out that just adding a reference is more clear on the intention of the gcc to not optimze this bit, rather than using a no-obvious annotation that seems to do the job.Thanks @eps1lon for the help