[compiler] Implement support for non-declaration for initializers #31712
+101
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mvitousek
added a commit
that referenced
this pull request
Dec 9, 2024
ghstack-source-id: 894914ab8c31b8b308cac05b07a0cc351419346e Pull Request resolved: #31712
…alizers" [ghstack-poisoned]
| for (42; i < 1; i += 1) {} | ||
| for (bar(); i < 1; i += 1) {} | ||
| for (; i < 1; i += 1) {} | ||
| for (i = 0; i < 1; i += 1) {} |
There was a problem hiding this comment.
let's test a more complex initializer value, like a logical expression, ternary, sequence expression, or optional.
| @@ -1354,6 +1354,8 @@ function codegenForInit( | |||
| init: ReactiveValue, | |||
| ): t.Expression | t.VariableDeclaration | null { | |||
| if (init.kind === 'SequenceExpression') { | |||
| // We may end up emitti | |||
| * emit as an expression instead | ||
| */ | ||
| cx.temp = temp; | ||
| return codegenInstructionValueToExpression(cx, init); |
There was a problem hiding this comment.
could this skip over remaining instructions? since it's exiting the loop and function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):