Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't read currentTransition back from internals #30991

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Don't read currentTransition back from internals #30991

merged 1 commit into from
Sep 17, 2024

Conversation

sebmarkbage
Copy link
Collaborator

This code is weird. It reads back the transition that it just set from the shared internals. It's almost like it expects it to be a getter or something.

This avoids that and makes it consistent with what ReactFiberHooks already does.

@sebmarkbage sebmarkbage requested a review from acdlite September 17, 2024 18:30
@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 6:32pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 17, 2024
@react-sizebot
Copy link

Comparing: 7b56a54...624c328

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.35 kB 509.35 kB = 91.10 kB 91.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.28 kB 514.24 kB = 91.82 kB 91.81 kB
facebook-www/ReactDOM-prod.classic.js = 604.86 kB 604.86 kB = 106.86 kB 106.86 kB
facebook-www/ReactDOM-prod.modern.js = 581.13 kB 581.16 kB = 103.01 kB 103.01 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 80ec164

@sebmarkbage sebmarkbage merged commit 15da917 into facebook:main Sep 17, 2024
184 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@sebmarkbage
Don't read currentTransition back from internals (#30991)
304fbae 
This code is weird. It reads back the transition that it just set from
the shared internals. It's almost like it expects it to be a getter or
something.

This avoids that and makes it consistent with what ReactFiberHooks
already does.

DiffTrain build for commit 15da917.
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@sebmarkbage
Don't read currentTransition back from internals (#30991)
2acc36c 
This code is weird. It reads back the transition that it just set from
the shared internals. It's almost like it expects it to be a getter or
something.

This avoids that and makes it consistent with what ReactFiberHooks
already does.

DiffTrain build for [15da917](15da917)
@vercel-release-bot vercel-release-bot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @acdlite @facebook-github-bot