[ci] combine compiler test runs into single CI job #30650
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 0e6d8c3...7c84798 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
`yarn workspaces run test` runs tests on all workspace members. All except the babel plugin tests are super cheap and mostly overhead. With the removed first job, total wall time might even be lower.
|
Oh, this would run tests for the playground which require playwright and so take longer. Never mind. |
There was a problem hiding this comment.
no strong opinions, if this turns out to be faster lets ship it! see my comment though about the playground tests, we need to filter that out somehow. it is actually the long pole for the compiler CI test runs because building the compiler and running it on the playground takes quite a while
| @@ -89,4 +72,4 @@ jobs: | |||
| path: "**/node_modules" | |||
| key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('compiler/**/yarn.lock') }} | |||
| - run: yarn install --frozen-lockfile | |||
| - run: yarn workspace ${{ matrix.workspace_name }} test | |||
| - run: yarn workspaces run test | |||
There was a problem hiding this comment.
something annoying about yarn workspaces is that this will run the test command on every package including the playground which is why I originally added that one liner to only find packages in that packages directory
yarn workspaces run testruns tests on all workspace members. All except the babel plugin tests are super cheap and mostly overhead. With the removed first job, total wall time might even be lower.